cmd: Add check for newer config file and an option to override it (fixes #4921)

[nekr0z]

Testing

Compiled and tested manually on linux-amd64, works as expected.

[AudriusButkevicius]

The error message should print the versions and suggest to use the option only of this is expected.

[nekr0z]

Fair point, will do. пн, 11 мар. 2019 г. в 20:44, Audrius Butkevicius <notifications@github.com>:

…

The error message should print the versions and suggest to use the option only of this is expected. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5597 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABceSGZbnZ15ZhjWI7UdrqhpNp7aL7Zlks5vVpYIgaJpZM4bpJWJ> .

[nekr0z]

Done.

[AudriusButkevicius]

In principle looks ok, other than the nitpick.

I wonder about refusing future configs via api like explained in the ticket, but I guess that's not very often that it would happen, as most users get, modify, post back.

[nekr0z]

I wonder about refusing future configs via api like explained in the ticket, but I guess that's not very often that it would happen, as most users get, modify, post back.

Should be doable, but lib/config is a little bit beyond my speaking go just yet. :(

[AudriusButkevicius]

I think -allow-newer-config would be the more correct term, as -allow-new-config is a bit ambigious, for example, if we already have a database, but no config in some distant future we might refuse to start, and option like that might be used to allow creation of a new config.

Again, I know I am annoying and it's a nit-pick, but I just want to be extra clear what the option means.

[AudriusButkevicius]

Sorry, given you are new contributor, I tend to look at PRs with more details and be annoying and picky :(

[nekr0z]

Sorry, given you are new, I tend to look at PRs with more details and be annoying and picky :(

Not only is it OK, but thank you for that! As a developer, I'm only starting to learn how to do things, and your input helps me a lot. As a user, the tighter code review the better.