lib: Skip deleted, locally changed on recv-enc folders (fixes #7153) #7154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calmh
approved these changes
Nov 27, 2020
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted items in a receive-encrypted folder must be tagged as a local change, as we mustn't send them to remotes. However those are not a problem, they are meant to be deleted, and thus shouldn't show up as locally changed. To filter those files out, we need to know the folder type. That information is not available in the db package. Thus in the api, instead of getting a db-snapshot from the model and getting locally changed items from that snapshot, this information is now directly obtained from the model (thus having all of these file list methods (need, remote-need, locally-changed) in the model. instead of spread between model and db).