Add windows/arm{,64} support #7947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting that https://data.syncthing.net/ shows one Windows user already patched go-ole and gopsutil locally, and is running on arm. |
:-) That would be me! I've been running Syncthing on Windows on ARM (ARM 32-bit for about 7ish months now, see #7445). |
AudriusButkevicius
approved these changes
Sep 17, 2021
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Sep 26, 2021
* main: (45 commits) build: Fix deepsource test & exclude patterns (syncthing#7969) build: Update all dependencies (syncthing#7968) lib/db: Replace SipHash with hash/maphash (syncthing#7962) gui: Removed superfluous quotes (fixes syncthing#7853) (syncthing#7961) gui, man, authors: Update docs, translations, and contributors lib/tlsutil: Allocate UnionedConnection in one go (syncthing#7912) build: Update go-ole for Windows/arm build: Add -arm flag to goversioninfo (syncthing#7947) gui, man, authors: Update docs, translations, and contributors gui: Sort already shared devices in edit folder modal (fixes syncthing#7940) (syncthing#7945) lib/model: Don't reset db while folder is running (fixes syncthing#7935) (syncthing#7936) lib/db: Inline sync.Once in releaser (syncthing#7938) all: Clarify 'Cleaning data for folder' log message (syncthing#7937) gui, man, authors: Update docs, translations, and contributors all: Unused args, retvals, assignments (syncthing#7926) lib/relay/protocol: Merge two Sprintf calls lib/discover, lib/protocol: Buffer allocation lib/model: Remove encryption pw on folder stop (syncthing#7925) lib/model: Add missing error assignment + Remove unused argument (syncthing#7922) gui: Move dismiss button after add/ignore buttons (syncthing#7848) ...
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
See #7445 .
go-ole/go-ole#223 has been merged.
Once shirou/gopsutil#1132 is merged, we should be able to target windows/arm and windows/arm64.