Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WebAuthn support to GUI (fixes #8409) #8417

Closed
wants to merge 34 commits into from
Closed

Add WebAuthn support to GUI (fixes #8409) #8417

wants to merge 34 commits into from

Commits on Jun 30, 2022

  1. Extract function createSession

    @emlun
    emlun committed Jun 30, 2022
    Configuration menu
    Copy the full SHA
    0ce39a7 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. Move HTTPS enablement check inside redirectToHTTPSMiddleware

    @emlun
    emlun committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    3995406 View commit details
    Browse the repository at this point in the history

  2. Redirect to HTTPS earlier in middleware chain

    @emlun
    emlun committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    dfe0592 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2022

  1. Add WebAuthn support

    @emlun
    emlun committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    a9c1304 View commit details
    Browse the repository at this point in the history

  2. Extract struct splitMux

    @emlun
    emlun committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    9785197 View commit details
    Browse the repository at this point in the history

  3. Add ExcludeCredentials

    @emlun
    emlun committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    9dea90a View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. Undo translations

    @emlun
    emlun committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    f3e6231 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. Rewrite GUIConfiguration changes in protobuf

    @emlun
    emlun committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    9d6f49f View commit details
    Browse the repository at this point in the history

  2. Don't use backwards-incompatible template string syntax

    @emlun
    emlun committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    c33d9aa View commit details
    Browse the repository at this point in the history

  3. Set excludeCredentials in frontend instead of backend for consistency… 

    … with UI state

Before, it was easy for backend state and UI state to end up with
conflicts. For example, if you delete a credential in the frontend and
attempt to register the same authenticator again before saving, the
backend would still include the deleted credential in
`excludeCredentials` and the authenticator wouldn't be able to be
registered again.

By instead setting `excludeCredentials` in the frontend, the above
scenario is no longer a problem because the `excludeCredentials`
setting is consistent with what's shown in the UI.

There is still a remaining state conflict, though: if you cancel the
settings dialog without saving, any credentials registered will remain
registered even though they "should" be removed because the UI state
wasn't explicitly saved.
    @emlun
    emlun committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    83e79d5 View commit details
    Browse the repository at this point in the history

  4. Move method configMuxBuilder.finish to config.Wrapper.Finish

    @emlun
    emlun committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    31ab9c7 View commit details
    Browse the repository at this point in the history

  5. Validate WebAuthn signature counter

    @emlun
    emlun committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    a2699a2 View commit details
    Browse the repository at this point in the history

  6. Use logger instead of fmt.Println to print errors

    @emlun
    emlun committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    bd23bb2 View commit details
    Browse the repository at this point in the history

  7. Add comment about missing transports field

    @emlun
    emlun committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    646b893 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2022

  1. Revert "Extract struct splitMux" 

    This reverts commit 9785197.
    @emlun
    emlun committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    95497b1 View commit details
    Browse the repository at this point in the history

  2. Move static assets under /static/ HTTP path

    @emlun
    emlun committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    ee9bfa6 View commit details
    Browse the repository at this point in the history

  3. Replace basic auth prompt with dedicated login endpoint

    @emlun
    emlun committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    a80dc40 View commit details
    Browse the repository at this point in the history

  4. Don't enable password auth if password is not set

    @emlun
    emlun committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    bd8bada View commit details
    Browse the repository at this point in the history

  5. Unset password when set to empty

    @emlun
    emlun committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    0114db5 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2022

  1. Add more warnings about WebAuth host config

    @emlun
    emlun committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    9bc23f5 View commit details
    Browse the repository at this point in the history

  2. Simplify webauthMux to webauthnService

    @emlun
    emlun committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    a40c2ce View commit details
    Browse the repository at this point in the history

  3. Show warnings on login page when WebAuthn is not available

    @emlun
    emlun committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    a4d5124 View commit details
    Browse the repository at this point in the history

  4. Show more WebAuthn error feedback

    @emlun
    emlun committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    ff66255 View commit details
    Browse the repository at this point in the history

  5. Don't drown console with errors on login page

    @emlun
    emlun committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    5ef2a58 View commit details
    Browse the repository at this point in the history

  6. Reload login page on auth error

    @emlun
    emlun committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    caf5b49 View commit details
    Browse the repository at this point in the history

  7. Add advanced setting sendBasicAuthPrompt to continue sending 401 resp… 

    …onses
    @emlun
    emlun committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    b5a1603 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2022

  1. Fix HTML tag mismatch 

    Co-authored-by: tomasz1986 <twilczynski@naver.com>
    @emlun @tomasz1986
    emlun and tomasz1986 committed Jul 17, 2022
    Configuration menu
    Copy the full SHA
    0ddf472 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from emlun/webauthn-keep-basic-auth 

    Add advanced setting sendBasicAuthPrompt to continue sending 401 responses
    @emlun
    emlun committed Jul 17, 2022
    Configuration menu
    Copy the full SHA
    b0b1420 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2023

  1. Merge remote-tracking branch 'upstream/main' into webauthn

    @emlun
    emlun committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    2efcfee View commit details
    Browse the repository at this point in the history

  2. Revert mux changes and moving static assets under /static/ 

    With the no-auth API exception added in commit 7a40240 (PR syncthing#8585), we can
extend that with a few more exceptions instead of restructuring the routing
muxes and moving the static assets.
    @emlun
    emlun committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    f147065 View commit details
    Browse the repository at this point in the history

  3. Move /authn/ API paths under /rest/noauth/

    @emlun
    emlun committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    7db89e9 View commit details
    Browse the repository at this point in the history

  4. Show error message if WebAuthn authentication is attempted without an… 

    …y credentials
    @emlun
    emlun committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    b8c5c74 View commit details
    Browse the repository at this point in the history

  5. Address review comments

    @emlun
    emlun committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    919bf3e View commit details
    Browse the repository at this point in the history

  6. Clean up new console.log statements

    @emlun
    emlun committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    456e968 View commit details
    Browse the repository at this point in the history