Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/beacon: Check FlagRunning #9051

Merged
merged 3 commits into from
Aug 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/beacon/broadcast.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func writeBroadcasts(ctx context.Context, inbox <-chan []byte, port int) error {

var dsts []net.IP
for _, intf := range intfs {
if intf.Flags&net.FlagBroadcast == 0 {
if intf.Flags&net.FlagRunning == 0 || intf.Flags&net.FlagBroadcast == 0 {
continue
}

Expand Down
2 changes: 1 addition & 1 deletion lib/beacon/multicast.go
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ func writeMulticasts(ctx context.Context, inbox <-chan []byte, addr string) erro

success := 0
for _, intf := range intfs {
if intf.Flags&net.FlagMulticast == 0 {
if intf.Flags&net.FlagRunning == 0 || intf.Flags&net.FlagMulticast == 0 {
continue
}

Expand Down
1 change: 0 additions & 1 deletion lib/upnp/upnp.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ func Discover(ctx context.Context, _, timeout time.Duration) []nat.Device {
wg := &sync.WaitGroup{}

for _, intf := range interfaces {
// Interface flags seem to always be 0 on Windows
if intf.Flags&net.FlagRunning == 0 || intf.Flags&net.FlagMulticast == 0 {
continue
}
Expand Down
Loading