Addresses logging failure and ENTESB-12633 #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sourcing base_functions.sh multiple times generates multiple temp log files, allocating the latest one to ERROR_FILE. This means no error ever gets properly logged. * Only generate new temp log file, the first time base_functions.sh is sourced. * Some errors from go scripts and openshift have 'error' in lowercase so are not properly handled by check_error. Upper-cases all error msgs to ensure latter properly handles them. * Surround oc commands with set -/+e in order to allow check_error to handle whatever errors may result. Ensures errors are added to ERROR_FILE and displayed at conclusion of script.
* Custom resource used to turn on those elements expected in the product including jaeger.
* default-cr.yml * The custom resource that is always loaded by the install_ocp.sh script * install_ocp.sh * Removes switches relating to changing the CR from the script * Simply passes the filename of the default-cr.yml to the operator rather than doing anything in code * Installs the camel-k crds by default to allow for possibility of that addon being enabled later on * Retains --force to actually recreate CR if required
|
Updated PR with extra commit which ... |
heiko-braun
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite ENTESB-12969, this creates a default syndesis CR in code ...