This repository has been archived by the owner on Nov 27, 2017. It is now read-only.
Cleanup Funktion leftovers #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lburgazzoli thanks ! I'm going to make a review soon but wanted to wait until TP2 is finally out before merging. |
|
No worries :) |
rhuss
reviewed
Nov 2, 2017
| @@ -43,6 +43,7 @@ public String toString() { | |||
| return "Filter: " + expression + " => " + getSteps(); | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
Constructor with expression should call super(KIND), too ?
Why is getKind() overwritten here ? (because of the @JsonIgnore in the super class ?
There was a problem hiding this comment.
Leftover leftover :)
| ObjectMapper mapper = new ObjectMapper(yamlFactory) | ||
| .setSerializationInclusion(JsonInclude.Include.NON_EMPTY) | ||
| .enable(SerializationFeature.INDENT_OUTPUT) | ||
| .disable(SerializationFeature.WRITE_EMPTY_JSON_ARRAYS) |
There was a problem hiding this comment.
WRITE_EMPTY_JSON_ARRAYS is deprecated (but already the default). So maybe just ommit it here ?
| return Optional.of(loadFromFile(folder)); | ||
| } | ||
| return Optional.empty(); | ||
| public final class SyndesisHelpers { |
There was a problem hiding this comment.
Maybe rename to YamlHelper (or something else) ?
| @@ -28,7 +28,7 @@ | |||
| */ | |||
| public static <T> List<T> notNullList(List<T> list) { | |||
There was a problem hiding this comment.
Can we inline the whole class ? Its seems to be used only in the ChoiceHandler ....
| public class SyndesisAutoConfiguration { | ||
| @Autowired | ||
| private ApplicationContext context; |
|
@rhuss done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This my first PR on syndesis-integration-runtime aimed to remove some funktion leftovers and custom bits.
@syndesisio/backend do you mind carefully review it ?