This repository has been archived by the owner on Jun 14, 2019. It is now read-only.
fix: don't reset OAuth client state #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to destroy the state received from backend on API call to
`/api/v1/connectors/{id}/credentials` in order for it not to overwrite
the cookie received on `/api/v1/credentials/callback`. This eliminates
the need to parse the cookie in `oauth-redirect.html` and pass/store it
in the app.
|
PR Storybook available here |
riccardo-forina
suggested changes
Jun 7, 2019
| @@ -97,8 +97,10 @@ export const ConfigurationPage: React.FunctionComponent = () => { | |||
| * the API in the document. This cookie will be later used by the BE in the | |||
| * redirect page set up in the 3rd party. | |||
| */ | |||
| if (connectResource) { | |||
| if (connectResource && connectResource.state) { | |||
There was a problem hiding this comment.
Oh I see the logic but the fix is not the mutation (never mutate an object in js), but rather wrapping this code in an useEffect to avoid it run on subsequent renders. I can do this in the next few if you want!
improvement: handle setting of the cookie in its own effect
|
PR Storybook available here |
chore: update the comments to reflect the new improved flow
|
PR Storybook available here |
|
Pull request approved by @riccardo-forina - applying approved label |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to destroy the state received from backend on API call to
/api/v1/connectors/{id}/credentialsin order for it not to overwrite the cookie received on/api/v1/credentials/callback. This eliminates the need to parse the cookie inoauth-redirect.htmland pass/store it in the app.