Skip to content
This repository has been archived by the owner on Jun 14, 2019. It is now read-only.

fix: undo really trivial styling issue that happened, nothing to see here honest #472

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

gashcrumb
Copy link
Collaborator

has nothing to do with syndesisio/syndesis#5732

@seanforyou23 shhh

Copy link
Member

@seanforyou23 seanforyou23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -3,14 +3,16 @@ import {
ServerEventsContext,
WithServerEvents,
} from '@syndesis/api';
// Don't move this line, otherwise we anger the pf4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have added a warning like this the first time around, good call!

@pure-bot
Copy link
Contributor

pure-bot bot commented Jun 13, 2019

Pull request approved by @seanforyou23 - applying approved label

1 similar comment
@pure-bot
Copy link
Contributor

pure-bot bot commented Jun 13, 2019

Pull request approved by @seanforyou23 - applying approved label

@pure-bot pure-bot bot added the approved label Jun 13, 2019
@riccardo-forina
Copy link
Collaborator

Wha? I don’t wanna know

@seanforyou23
Copy link
Member

@riccardo-forina it looks like if we import anything from @syndesis/ui before we import the main App import { App, ... } from './app'; then the order of injected css styles is wrong in the resulting DOM. App needs to load first before other component stylesheets since it is what's importing the base styles (which contain resets).

Could probably refactor how these imports are structured but for now this get's us back to the stable point we've been seeing all week. I know you said you didn't wanna know, but I wanted you to know :)

@riccardo-forina
Copy link
Collaborator

Now I want to unknown it all.

@riccardo-forina
Copy link
Collaborator

PR Storybook available here

@gashcrumb gashcrumb merged commit 0ebbe84 into syndesisio:master Jun 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants