findbugs(server-endpoint): This is a false positive, result can be nu…

…ll here. See spotbugs/spotbugs#259
syndesisio · Jul 3, 2020 · adbad8d · adbad8d
1 parent ae7f6c6
commit adbad8d
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/...src/main/java/io/syndesis/server/endpoint/v1/handler/connection/ConnectorIconHandler.java b/...src/main/java/io/syndesis/server/endpoint/v1/handler/connection/ConnectorIconHandler.java
@@ -31,6 +31,7 @@
 import static javax.ws.rs.core.HttpHeaders.CONTENT_LENGTH;
 import static javax.ws.rs.core.HttpHeaders.CONTENT_TYPE;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import io.swagger.v3.oas.annotations.tags.Tag;
 import io.swagger.v3.oas.annotations.Operation;
 import io.swagger.v3.oas.annotations.responses.ApiResponse;
@@ -72,6 +73,7 @@ public final class ConnectorIconHandler extends BaseHandler {
     @ApiResponse(responseCode = "200", description = "Updated Connector icon")
     @Produces(MediaType.APPLICATION_JSON)
     @Consumes(MediaType.MULTIPART_FORM_DATA)
+    @SuppressFBWarnings
     @SuppressWarnings("PMD.CyclomaticComplexity")
     public Connector create(MultipartFormDataInput dataInput) {
         if (dataInput == null || dataInput.getParts() == null || dataInput.getParts().isEmpty()) {
@@ -86,6 +88,10 @@ public Connector create(MultipartFormDataInput dataInput) {
             InputPart filePart = dataInput.getParts().iterator().next();
             try (InputStream result = filePart.getBody(InputStream.class, null)) {
 
+                if (result == null) {
+                    throw new IllegalArgumentException("Can't find a valid 'icon' part in the multipart request");
+                }
+
                 try (BufferedInputStream iconStream = new BufferedInputStream(result)) {
                     MediaType mediaType = filePart.getMediaType();
                     if (!mediaType.getType().equals("image")) {