Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Step: UX Design #332

Closed
syndesis-bot opened this issue Nov 15, 2017 · 21 comments
Closed

Log Step: UX Design #332

syndesis-bot opened this issue Nov 15, 2017 · 21 comments
Assignees
Labels
cat/design concrete UX design. Use this for PRs containing UX designs. group/uxd User experience (UX) designs
Milestone

Comments

@syndesis-bot
Copy link
Collaborator

@sjcox-rh 2017-11-14 UX Design

Please reference https://docs.google.com/document/d/15qq-mIf_EAV2bEgbg44zXDMTI-ev1QChGriiwlulRA0/edit

Designs for adding a log step in integration workflow. As a citizen user, I would like to add one or more steps to an integration flow that allow me to log context around the processing of the integration.

Also have to design how and where the user will view these logs. Also comes with log viewer.

@syndesis-bot syndesis-bot added cat/design concrete UX design. Use this for PRs containing UX designs. group/uxd User experience (UX) designs labels Nov 15, 2017
@chirino chirino added this to the Sprint 23 milestone Jan 16, 2018
@amysueg
Copy link

amysueg commented Jan 16, 2018

@sjcox-rh is working on this - adding her to the issue

@amysueg amysueg modified the milestones: Sprint 23, Sprint 24 Jan 29, 2018
@paoloantinori
Copy link
Contributor

Hi, I'm checking the stories currently still in Inbox column for Spring 24. https://github.com/syndesisio/syndesis/issues#boards?milestones=Sprint%2024%232018-02-16&repos=105563335

Do you have any update on this?

thank you

@amysueg
Copy link

amysueg commented Feb 12, 2018

@sjcox-rh - this is the last one to ask for your input. thanks SJ! bitmoji

@sjcox-rh
Copy link
Contributor

@paoloantinori Sharing designs with UX team tomorrow to get initial feedback. Then will share designs for rest of team!

fyi, @amysueg

@paoloantinori
Copy link
Contributor

hi @sjcox-rh do you have any update on this?

@sjcox-rh
Copy link
Contributor

Here are initial designs for the log step. Please let me know if you have any comments on questions. Since this is the first round, I'm sure there will be some updates needed. I referenced the Log brain dump doc from last year so not sure if there have been any changes on requirements. Last I checked it was still relevant.

@iocanel, since you have been working on the POC was hoping to get your input on this.

choose a step

configure step

configure step - dropdown and tooltip

custom editor

fyi, @paoloantinori @chirino @kcbabo @rhuss @amysueg @michael-coker @seanforyou23

@kcbabo
Copy link

kcbabo commented Feb 16, 2018

Thanks for creating the initial designs, SJ! My comments:

  • There should not be a dropdown for log level.
  • There should not be a preview window unless this is just a static example of what the log content will look like.
  • The input for the custom text option needs to be much larger. A multi-line text area would be good.
  • I don't think we need a custom editor tab. The custom text input should be enough on the main tab.

@gashcrumb
Copy link
Contributor

Not sure what we have at the backend to support validate?

We could just make the custom text input a text area. Later on we could probably also consider making the text area a fancier editor. Most likely then we're pretty close to not having to write a custom page which would save us a lot of time on the UI side.

@kcbabo
Copy link

kcbabo commented Feb 16, 2018

I think we originally said we could hang a validate method off of the REST API that took a Simple language expression and just did an eval on it to validate syntax. I'm fine with punting that if we don't have time. Agree that avoiding a custom page and saving time would be optimal.

@sjcox-rh
Copy link
Contributor

@kcbabo @gashcrumb

I made the changes you suggested. Removed custom editor option along with Validate action. Replaced the drop down with check boxs for log level. Also provided 2 options for the updated designs.

Option 1:
configure step

Option 2:
configure step copy

@kcbabo
Copy link

kcbabo commented Feb 16, 2018

Hey @sjcox-rh The new designs still have the log level (Errors, Warning, etc.). That should be removed completely.

Based on the conversation with Stan, I don't think we need a Preview pane.

@amysueg amysueg removed their assignment Feb 16, 2018
@sjcox-rh
Copy link
Contributor

@kcbabo sorry for the confusion, I'll remove those. So jsut to confirm, the only content we will show is "Select the log entry content" with the 3 options via checkboxes and the custom text input field?

@kcbabo
Copy link

kcbabo commented Feb 21, 2018

Yep, that sounds good.

@iocanel
Copy link
Contributor

iocanel commented Feb 26, 2018

For message header, it doesn't really make sense to have it as a checkbox. It should be a text-field, in which the user should enter one or more headers that need to be displayed.

@kcbabo
Copy link

kcbabo commented Feb 27, 2018

So "Message Header" should actually be "Message Headers". The idea is that checking that box will dump all message headers to the log. If a user wants to log a specific header value they can use simple language expression in the custom text entry.

@iocanel
Copy link
Contributor

iocanel commented Feb 27, 2018

Makes sense!
Do we have any plans for exchange properties?

@kcbabo
Copy link

kcbabo commented Feb 27, 2018

We could rename the checkbox as "Message Context" and print both headers and properties. I don't think we want to add separate checkboxes for headers and properties - users won't have any idea what those mean.

@iocanel
Copy link
Contributor

iocanel commented Feb 27, 2018 via email

@sjcox-rh
Copy link
Contributor

sjcox-rh commented Mar 6, 2018

PR created! Please review issue #1852

@amysueg
Copy link

amysueg commented Mar 9, 2018

@sjcox-rh - ok to close this issue now?

@paoloantinori paoloantinori removed this from the Sprint 24 milestone Mar 12, 2018
@paoloantinori paoloantinori added this to the Sprint 25 milestone Mar 12, 2018
@sjcox-rh
Copy link
Contributor

@amysueg yup! I'll close it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/design concrete UX design. Use this for PRs containing UX designs. group/uxd User experience (UX) designs
Projects
None yet
Development

No branches or pull requests

8 participants