Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage CI/CD UI doesn't check duplicates #6362

Closed
mkralik3 opened this issue Aug 13, 2019 · 1 comment
Closed

Manage CI/CD UI doesn't check duplicates #6362

mkralik3 opened this issue Aug 13, 2019 · 1 comment
Assignees
Labels
cat/bug A bug which needs fixing closed/migrated prio/p0 The priority of a bug. p0 means blocking source/qe Raised by QE zenhub/backlog
Milestone

Comments

@mkralik3
Copy link
Contributor

mkralik3 commented Aug 13, 2019

See also https://issues.jboss.org/browse/ENTESB-11386

This is a...


[ ] Feature request
[x] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Documentation issue or request

Description

When I want to create a new tag with the same name as has the existed tag, I am able to click on Save button (however the tag is not created because the backend returns 400 "developerMsg":"Duplicate environment tag1").

When I want to rename a tag to the same name as has another tag, I am able to click on Save button and in the UI I see two duplicated tags.
image

In the 1.7.x, the dialog for creating/updating the tag was checking whether the name is already used.
In the left side of the images is master, in the right side is 1.7.13 (CR3)
Creating the tag with the same name:
image
Updating to the same name:
image

The UI should check the duplicities as before.
The endpoint PUT .../api/v1/public/environments/<tag> should check whether the name in params is not already used by another tag.

Step to reproduce:

  • Go to Manage CI/CD page
  • Create tag with name tag1
  • Try to create tag1 again
  • Create tag with name tag2
  • Try to rename tag2 to tag1
@mkralik3 mkralik3 added cat/bug A bug which needs fixing prio/p0 The priority of a bug. p0 means blocking source/qe Raised by QE labels Aug 13, 2019
@pure-bot pure-bot bot added the notif/triage The issue needs triage. Applied automatically to all new issues. label Aug 13, 2019
@gaughan gaughan removed the notif/triage The issue needs triage. Applied automatically to all new issues. label Aug 15, 2019
@gaughan gaughan added this to the Sprint 50 (1/4) milestone Aug 15, 2019
dhirajsb added a commit to dhirajsb/syndesis that referenced this issue Sep 2, 2019
…refactored public-api into an environment handler that stores all tag names as Environment json objects
dhirajsb added a commit to dhirajsb/syndesis that referenced this issue Sep 2, 2019
…refactored public-api into an environment handler that stores all tag names as Environment json objects
dhirajsb added a commit to dhirajsb/syndesis that referenced this issue Sep 3, 2019
…refactored public-api into an environment handler that stores all tag names as Environment json objects
dhirajsb added a commit to dhirajsb/syndesis that referenced this issue Sep 4, 2019
…refactored public-api into an environment handler that stores all tag names as Environment json objects
dhirajsb added a commit to dhirajsb/syndesis that referenced this issue Sep 5, 2019
…refactored public-api into an environment handler that stores all tag names as Environment json objects
dhirajsb added a commit to dhirajsb/syndesis that referenced this issue Sep 6, 2019
…refactored public-api into an environment handler that stores all tag names as Environment json objects
dhirajsb added a commit to dhirajsb/syndesis that referenced this issue Sep 6, 2019
…refactored public-api into an environment handler that stores all tag names as Environment json objects
@heiko-braun
Copy link
Collaborator

@pure-bot pure-bot bot locked as resolved and limited conversation to collaborators Sep 7, 2019
@pure-bot pure-bot bot reopened this Sep 7, 2019
@pure-bot pure-bot bot unlocked this conversation Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/bug A bug which needs fixing closed/migrated prio/p0 The priority of a bug. p0 means blocking source/qe Raised by QE zenhub/backlog
Projects
None yet
Development

No branches or pull requests

4 participants