Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #4755, avoid adding duplicate tag names #4783

Merged
merged 2 commits into from Mar 6, 2019
Merged

Fixes #4755, avoid adding duplicate tag names #4783

merged 2 commits into from Mar 6, 2019

Conversation

dhirajsb
Copy link
Contributor

@dhirajsb dhirajsb commented Mar 6, 2019

No description provided.

@dhirajsb dhirajsb added the pr/wip Mark work-in-progress with this label. pure-bot won't merge a PR if this is set. label Mar 6, 2019
@dhirajsb dhirajsb added this to the Sprint 42 (3/4) milestone Mar 6, 2019
@dhirajsb dhirajsb force-pushed the cicd-services branch 2 times, most recently from 288c688 to 0b9c512 Compare March 6, 2019 18:42
@dhirajsb dhirajsb added pr/wip Mark work-in-progress with this label. pure-bot won't merge a PR if this is set. and removed pr/wip Mark work-in-progress with this label. pure-bot won't merge a PR if this is set. labels Mar 6, 2019
@dhirajsb dhirajsb force-pushed the cicd-services branch 2 times, most recently from 3499dc7 to a8de903 Compare March 6, 2019 21:51
@dhirajsb dhirajsb removed the pr/wip Mark work-in-progress with this label. pure-bot won't merge a PR if this is set. label Mar 6, 2019
@dhirajsb dhirajsb mentioned this pull request Mar 6, 2019
Closed
@dhirajsb dhirajsb requested a review from gashcrumb March 6, 2019 21:53
@pure-bot pure-bot bot added the pr/review-requested Use this if you want to have a review. pure-bot will prevent merging if set and no review given label Mar 6, 2019
gashcrumb
gashcrumb approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@gashcrumb gashcrumb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a bunch!

@pure-bot
Copy link
Contributor

pure-bot bot commented Mar 6, 2019

Pull request approved by @gashcrumb - applying pr/approved label

@pure-bot pure-bot bot added the pr/approved Applied by pure-bot when a review is approved label Mar 6, 2019
@pure-bot pure-bot bot merged commit fc2e366 into syndesisio:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gashcrumb gashcrumb gashcrumb approved these changes

Assignees
No one assigned
Labels
pr/approved Applied by pure-bot when a review is approved pr/review-requested Use this if you want to have a review. pure-bot will prevent merging if set and no review given
Projects
None yet
Milestone
Sprint 42 (3/4)
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhirajsb @gashcrumb