Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(5330): Moves the todo app to addons directory #5399

Closed
wants to merge 1 commit into from

Commits on May 17, 2019

  1. fix(5330): Moves the todo app to addons directory

    * syndesis.yml
     * Strips out sampledb & todo & relocates them to install/addons
    
    * .../commands/[install|util/openshift_funcs]
     * Adds a --addons switch that takes a comma-separated list of addons to
       install in addition to base syndesis components. At the moment this
       list would be "db-sampledb,todo"
    
    * main.go
     * Adds in default of /conf/addons to turn on addons support
    
    * syndesis_types.go
     * Adds additional fields to structs for extra environment variables, inc.
       Addons (which contains the preferred set of addons)
    
    * templateprocessor.go
     * To fully support sampledb and todo moving to addons, the env vars from
       the syndesis template must be available. This is due to the sample-db
       being a full copy of the syndesis-db resource with the extra sample-db
       elements included.
    
    * action/[install|upgrade].go
     * When installing addons:
      - Check their is some in the directory
      - Find the addon resources and get each addon ID
      - If addon ID is included in the list specified by --addons switch then
        install
    
    * addon/install.go
     * Both sampledb & todo have env vars that must have values injected in
       them before the resource is loaded. The template has the templateprocessor
       that does the same. loadAndProcessFile() conducts a string replace over
       each file ensuring env vars are correctly substituted for their values
     * Since the metadata.name of each resource is not unique then it is
       essential that each resource has a managed ID that can be used to
       select it for install. The syndesis.io/addon label provides this. It
       doesn't need to be unique as all the todo resources have the same ID.
    
    * configuration.go
     * Add in extra env vars required by addons, inc. addons
    phantomjinx committed May 17, 2019
    Configuration menu
    Copy the full SHA
    44fc4f2 View commit details
    Browse the repository at this point in the history