Add integration tests

[lgarciaaco]

This PR creates the infrastructure for e2e tests for the operator and adds two basic integration tests. installWithDefaultsTest test the installation of sydensis when an empty CR is created. installTest uses a populated CR.

Did some cleanup.

Closes #6353

[zregvart]

I'm wondering what happens to the syndesis-operator role creation when cluster doesn't have some of the resources that the role references installed (Camel K, Integreatly CRs?)

The tests look at the status of the Syndesis CR to assert it was installed, should we put more asserts towards asserting that deployment configs or other resources are created?

[zregvart]

this changed from rbac.authorization.k8s.io/v1 to rbac.authorization.k8s.io/v1beta1, should it have?

[lgarciaaco]

same as the next comment

[zregvart]

Should this be?

Suggested change

	apiVersion: rbac.authorization.k8s.io/v1beta1
	apiVersion: rbac.authorization.k8s.io/v1

[lgarciaaco]

you probably right, I blindly copy from

syndesis/install/operator/pkg/generator/assets/install/operator.yml.tmpl

Line 13 in e14633a

apiVersion: rbac.authorization.k8s.io/v1beta1

, maybe @chirino can shed some lights

[zregvart]

Perhaps like this, to distinguish from the operator? Not sure what labels we set on other service accounts...

Suggested change

	syndesis.io/type: operator
	syndesis.io/type: service-account

[lgarciaaco]

It seems to refers to the components the system account is managing, for instance:

syndesis/install/operator/pkg/generator/assets/infrastructure/04-syndesis-server.yml.mustache

Lines 1 to 9 in e14633a

	- apiVersion: v1
	kind: ServiceAccount
	metadata:
	name: syndesis-server
	labels:
	app: syndesis
	syndesis.io/app: syndesis
	syndesis.io/type: infrastructure
	syndesis.io/component: syndesis-server

or

syndesis/install/operator/pkg/generator/assets/infrastructure/02-syndesis-service-accounts.yml.mustache

Lines 1 to 9 in e14633a

	- apiVersion: v1
	kind: ServiceAccount
	metadata:
	name: syndesis-default
	labels:
	app: syndesis
	syndesis.io/app: syndesis
	syndesis.io/type: infrastructure
	syndesis.io/component: syndesis-infrastructure

so I guess operator is acceptable, but not sure whether we have some guidelines for it, this was again a c&p from:

syndesis/install/operator/pkg/generator/assets/install/operator.yml.tmpl

Line 9 in e14633a

syndesis.io/type: operator

[zregvart]

does go-fmt like this? I thought we were using tabs in Golang code

[lgarciaaco]

@zregvart

I'm wondering what happens to the syndesis-operator role creation when cluster doesn't have some of the resources that the role references installed (Camel K, Integreatly CRs?)

The test suite uses the resources in https://github.com/syndesisio/syndesis/tree/master/install/operator/deploy, if the CRD is missing it will attempt to create it. This tests only need syndesis CRDs atm, I guess as we incorporate more tests that use other CRDs (like kamel), we would have to move those tho the crd folder

The tests look at the status of the Syndesis CR to assert it was installed, should we put more asserts towards asserting that deployment configs or other resources are created?

Definitely!! This is just the bare structure to start adding more on top of that, the fun is just starting ;)