Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENTESB-11263: Add scheduled to CR for meta, server, ui and s2i #6512

Merged
merged 3 commits into from Sep 16, 2019

Conversation

lgarciaaco
Copy link
Contributor

For ImageStreams, tweak importPolicy.scheduled by setting a parameter in the CR

For example:

apiVersion: syndesis.io/v1alpha1
kind: Syndesis
metadata:
  name: app
spec:
  components:
    meta:
      scheduled: true

Will end up in IS syndesis-meta having

      importPolicy:
        scheduled: true

or false.

@pull-request-size pull-request-size bot added the size/l Large label Sep 4, 2019
@heiko-braun
Copy link
Collaborator

What if we make it global settings that applies to all ImageStreams? I think you might want to enable for all or none.

@lgarciaaco
Copy link
Contributor Author

One downside of this approach is that the default value of a boolean is false, therefore if Syndesis.Spec.Components.Scheduled is omitted in the CR, importPolicy.scheduled will go to false which is not what we want by default.

@heiko-braun
Copy link
Collaborator

importPolicy.scheduled will go to false which is not what we want by default.

I don't know, for product builds that seems to be right, for development probably not

@heiko-braun heiko-braun changed the title Add scheduled to CR for meta, server, ui and s2i ENTESB-11263: Add scheduled to CR for meta, server, ui and s2i Sep 7, 2019
@lgarciaaco lgarciaaco marked this pull request as ready for review September 9, 2019 08:09
@pure-bot pure-bot bot added the pr/review-requested Use this if you want to have a review. pure-bot will prevent merging if set and no review given label Sep 9, 2019
Copy link
Contributor

@asmigala asmigala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pure-bot
Copy link
Contributor

pure-bot bot commented Sep 16, 2019

Pull request approved by @asmigala - applying pr/approved label

@pure-bot pure-bot bot added the pr/approved Applied by pure-bot when a review is approved label Sep 16, 2019
@pure-bot pure-bot bot merged commit 7a7964b into syndesisio:master Sep 16, 2019
@lgarciaaco lgarciaaco deleted the ENTESB-11263 branch October 29, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/approved Applied by pure-bot when a review is approved pr/review-requested Use this if you want to have a review. pure-bot will prevent merging if set and no review given size/l Large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants