Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ENTESB-11647) - Preview section updates for improved usability #6718

Merged
merged 2 commits into from Sep 25, 2019

Conversation

elvisisking
Copy link
Contributor

@elvisisking elvisisking commented Sep 24, 2019

  • See ENTESB-11647
  • preview results empty state is now centered and uses full width
  • updated preview empty results text as recommended
  • changed preview results icon text as recommended
  • added label above preview results as recommended to tell user the number of result rows
  • added min-height to DdlEditor to prevent it from getting too small when query results exist

@pure-bot pure-bot bot added the pr/review-requested Use this if you want to have a review. pure-bot will prevent merging if set and no review given label Sep 24, 2019
@syndesisio-bot
Copy link

@elvisisking The bot could not transition the ticket automatically, please update this Jira ticket manually: https://issues.jboss.org/browse/ENTESB-11647

@pull-request-size pull-request-size bot added the size/l Large label Sep 24, 2019
- preview results empty state is now centered and uses full width
- updated preview empty results text as recommended
- changed preview results icon text as recommended
- added label above preview results as recommended to tell user the number of result rows
- added `min-height` to DdlEditor to prevent it from getting too small when query results exist
- the `Refresh` icon is now centered with the middle of the `Refresh` label
- "Number of Rows" has been changed to "Number of rows"
Copy link
Contributor

@mdrillin mdrillin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pure-bot
Copy link
Contributor

pure-bot bot commented Sep 25, 2019

Pull request approved by @mdrillin - applying pr/approved label

@pure-bot pure-bot bot added the pr/approved Applied by pure-bot when a review is approved label Sep 25, 2019
@pure-bot pure-bot bot merged commit 7f128c3 into syndesisio:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.8.x pr/approved Applied by pure-bot when a review is approved pr/review-requested Use this if you want to have a review. pure-bot will prevent merging if set and no review given size/l Large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants