Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ENTESB-11758): Fix form field rendering on metadata lookup #6757

Conversation

christophd
Copy link
Contributor

Restores old behavior (before data list feature) where we use select dropdown by default. Only use dataList for those fields marked accordingly in the connector json (just used by Google Sheets at the moment).

When only one single value is suggested pick this as default value so it is preselected in dropdowns and dataList components.

Fixes ENTESB-11758

@pure-bot pure-bot bot added pr/review-requested Use this if you want to have a review. pure-bot will prevent merging if set and no review given labels Sep 26, 2019
@christophd
Copy link
Contributor Author

christophd commented Sep 26, 2019

This is related to former changes in metadata lookup logic where we decided to use dataList as default rendering option. This decision is now reverted

#5690
#5191

Restores old behavior (before data list feature) where we use select dropdown by default. Only use dataList for those fields marked accordingly in the connector json (just used by Google Sheets at the moment).

Fixes ENTESB-11758
@christophd christophd force-pushed the issue/11758/metadata-lookup-form-field-rendering branch from 71d8122 to 6e74f01 Compare September 26, 2019 18:00
@pure-bot
Copy link
Contributor

pure-bot bot commented Sep 26, 2019

Pull request approved by @zregvart - applying pr/approved label

Copy link
Member

@zregvart zregvart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cc @gashcrumb

@pure-bot pure-bot bot added the pr/approved Applied by pure-bot when a review is approved label Sep 26, 2019
@christophd christophd merged commit 3ec25b7 into syndesisio:master Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.8.x pr/approved Applied by pure-bot when a review is approved pr/review-requested Use this if you want to have a review. pure-bot will prevent merging if set and no review given
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants