New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENTESB-11772: Generate a template from the operator configuration #6845
Conversation
Labelled as WIP at the moment in case major changes required. |
Execute command: Generates -> syndesis.yml |
Pretty cool, thanks Paul |
Pull request approved by @lgarciaaco - applying pr/approved label |
* Parses the internal operator configuration and exports an openshift template * install/install.go * Adds in the "forge" command for forging the template * eg. syndesis-operator install forge \ --operator-config ./build/conf/config.yaml \ --addons todo --eject yaml * install-forge.go * Does the work of generating the new openshift template * configuration.go * Enhances the config constants by mapping them to their descriptions, default values, whether required and whether generated * template/install.go * Utilise the AllConfigMap for providing the default values
ac108c4
to
f4a94d3
Compare
@lgarciaaco @phantomjinx Is there a reason not to merge to 1.8.x? |
Just did a trial merge to 1.8.x local branch and seems straightforward so can backport if required. @lgarciaaco |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport 1.8.x
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick f4a94d33f27082ca4fc119328d46cd4350e9bc36
# Create a new branch with these backported commits.
git checkout -b backport-6845-to-1.8.x
# Push it to GitHub.
git push --set-upstream origin backport-6845-to-1.8.x
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport Then, create a pull request where the |
@phantomjinx Can you create a PR manually? The bot doesn't seem to be capable of doing it. |
Parses the internal operator configuration and exports an openshift
template
install/install.go
Adds in the "forge" command for forging the template
eg. syndesis-operator install forge
--operator-config ./build/conf/config.yaml
--addons todo --eject yaml
install-forge.go
Does the work of generating the new openshift template
configuration.go
Enhances the config constants by mapping them to their descriptions,
default values, whether required and whether generated
template/install.go
Utilise the AllConfigMap for providing the default values