Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch updates on the detail page when change events are received #6938

Merged
merged 1 commit into from Oct 16, 2019
Merged

fix: fetch updates on the detail page when change events are received #6938

merged 1 commit into from Oct 16, 2019

Conversation

gashcrumb
Copy link
Contributor

@gashcrumb gashcrumb commented Oct 16, 2019

for ENTESB-11405

@claudio4j this is what I was thinking in regards to the server events.

Looking deeper I think I led you astray a bit, useConnection returns a read() function that can be used to trigger a fetch, so another option would have been to call read() after calling the save function. But this approach should work as well, after going through the oauth dance once there's a change made to the connection the UI should then fetch an updated connection.

I can't seem to fully see this working in development mode though, it seems like the dev proxy isn't receiving the change events for some reason. Can you test this in your environment? You'd want to build the console and deploy it to verify I think, open the network tab and you should see a GET occur shortly after the ui does that PUT.

@pull-request-size pull-request-size bot added the size/s Small label Oct 16, 2019
@claudio4j
Copy link
Contributor

This change fixes the https://issues.jboss.org/browse/ENTESB-11405 bug.

@gashcrumb gashcrumb added the pr/approved Applied by pure-bot when a review is approved label Oct 16, 2019
@pure-bot pure-bot bot merged commit 2fb60c6 into syndesisio:master Oct 16, 2019
@gashcrumb gashcrumb deleted the connection-detail-events branch December 5, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/approved Applied by pure-bot when a review is approved size/s Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants