Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENTESB-12268 Integration uptime doesn't contain any data #7142

Merged

Conversation

claudio4j
Copy link
Contributor

@pure-bot pure-bot bot added the pr/review-requested Use this if you want to have a review. pure-bot will prevent merging if set and no review given label Nov 14, 2019
@claudio4j claudio4j removed the request for review from kahboom November 14, 2019 20:00
@pure-bot pure-bot bot removed the pr/review-requested Use this if you want to have a review. pure-bot will prevent merging if set and no review given label Nov 14, 2019
@zregvart
Copy link
Member

zregvart commented Nov 15, 2019

Perhaps also related to #7143, not sure if we would like to provide the time in seconds and the UI multiplies by 1000 or the backend provides the value in miliseconds and the UI takes the value verbatim.

Any thoughts @gashcrumb?

@gashcrumb
Copy link
Contributor

gashcrumb commented Nov 15, 2019 via email

@gashcrumb
Copy link
Contributor

The other option btw is to maybe as a convention include the time unit as part of the property name, that way anybody coming along and looking can understand what's going on without having to stare at the value or see it convert to some date in the 70s :-)

@claudio4j
Copy link
Contributor Author

I found Zoran suggestion better, do it on server. I am testing this option and will push the commit today. Thanks for the review.

@claudio4j
Copy link
Contributor Author

Perhaps also related to #7143

This fix the above issue.

@claudio4j claudio4j merged commit a8daee4 into syndesisio:master Nov 20, 2019
@claudio4j claudio4j deleted the fix_metric_dates_ENTESB-12268 branch November 26, 2019 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants