New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENTESB-12268 Integration uptime doesn't contain any data #7142
ENTESB-12268 Integration uptime doesn't contain any data #7142
Conversation
Perhaps also related to #7143, not sure if we would like to provide the time in seconds and the UI multiplies by 1000 or the backend provides the value in miliseconds and the UI takes the value verbatim. Any thoughts @gashcrumb? |
Consistency would be better, if the UI can just use a value without having
to modify it first, that'd be better IMO
…On Fri, Nov 15, 2019, 4:02 AM Zoran Regvart ***@***.***> wrote:
Perhaps also related to #7143
<#7143>, not sure if we
would like to provide the time in seconds and the UI does the multiply by
1000 or the backend provides the value in miliseconds and the UI takes the
value verbatim.
Any thoughts @gashcrumb <https://github.com/gashcrumb>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7142?email_source=notifications&email_token=AACV3LAXLYYCCTWLNIG62P3QTZQRRA5CNFSM4JNQ3FU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEEYWNY#issuecomment-554273591>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACV3LH6ISCCL45KXPOOA2DQTZQRRANCNFSM4JNQ3FUQ>
.
|
app/ui-react/packages/ui/src/Integration/Metrics/IntegrationDetailMetrics.tsx
Outdated
Show resolved
Hide resolved
app/ui-react/syndesis/src/modules/integrations/pages/detail/MetricsPage.tsx
Outdated
Show resolved
Hide resolved
The other option btw is to maybe as a convention include the time unit as part of the property name, that way anybody coming along and looking can understand what's going on without having to stare at the value or see it convert to some date in the 70s :-) |
I found Zoran suggestion better, do it on server. I am testing this option and will push the commit today. Thanks for the review. |
a96e272
to
f1eb4ec
Compare
This fix the above issue. |
https://issues.jboss.org/browse/ENTESB-12268