Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework some configuration fields #7153

Merged
merged 6 commits into from Dec 4, 2019
Merged

Rework some configuration fields #7153

merged 6 commits into from Dec 4, 2019

Conversation

lgarciaaco
Copy link
Contributor

  • Include ManagementUrlFor3scale and IntegrationStateCheckInterval back in the CR
  • Set IntegrationLimit and DeployIntegrations via environment variables
  • Include DemoData back into the CR in the root of the CR

Fixes: https://issues.jboss.org/browse/ENTESB-12280

Rework some configuration fields
328a3d0 
- Include ManagementUrlFor3scale and IntegrationStateCheckInterval back in the CR
- Set IntegrationLimit and DeployIntegrations via environment variables
- Include DemoData back into the CR in the root of the CR
@syndesisio-bot
Copy link

@lgarciaaco The bot could not transition the ticket automatically, please update this Jira ticket manually: https://issues.jboss.org/browse/ENTESB-12280

@pull-request-size pull-request-size bot added the size/l Large label Nov 18, 2019
@pure-bot pure-bot bot added the pr/review-requested Use this if you want to have a review. pure-bot will prevent merging if set and no review given label Nov 18, 2019
@lgarciaaco lgarciaaco added the pr/wip Mark work-in-progress with this label. pure-bot won't merge a PR if this is set. label Nov 18, 2019
@lgarciaaco lgarciaaco removed the pr/wip Mark work-in-progress with this label. pure-bot won't merge a PR if this is set. label Nov 18, 2019
@lgarciaaco
Copy link
Contributor Author

@avano @mcada I have included your feedback from our previous discussions, can you please have a look?

@lgarciaaco
Copy link
Contributor Author

Fixes #6356

@lgarciaaco lgarciaaco mentioned this pull request Dec 3, 2019
Closed
@pure-bot
Copy link
Contributor

pure-bot bot commented Dec 4, 2019

Pull request approved by @avano - applying pr/approved label

@pure-bot pure-bot bot added the pr/approved Applied by pure-bot when a review is approved label Dec 4, 2019
@lgarciaaco lgarciaaco added the group/operator Infrastructure operator related label Dec 4, 2019
@lgarciaaco
Copy link
Contributor Author

Operator tests passed, I am merging this

@lgarciaaco lgarciaaco merged commit 16f282b into syndesisio:master Dec 4, 2019
@syndesisio-bot
Copy link

@lgarciaaco The bot could not transition the ticket automatically, please update this Jira ticket manually: https://issues.jboss.org/browse/ENTESB-12280

@lgarciaaco lgarciaaco deleted the cr_rework branch December 4, 2019 12:11
This was referenced Dec 4, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avano avano avano approved these changes

@phantomjinx phantomjinx Awaiting requested review from phantomjinx

@asmigala asmigala Awaiting requested review from asmigala

Assignees
No one assigned
Labels
group/operator Infrastructure operator related pr/approved Applied by pure-bot when a review is approved pr/review-requested Use this if you want to have a review. pure-bot will prevent merging if set and no review given size/l Large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lgarciaaco @syndesisio-bot @avano