Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ENTESB-12218): Wrong usage of Optional.of() in server-api-generator #7281

Merged

Conversation

christophd
Copy link
Contributor

Fix wrong usage of Optional.of() in favor of using Optional.ofNullable().

@syndesisio-bot
Copy link

@christophd The bot could not transition the ticket automatically, please update this Jira ticket manually: https://issues.jboss.org/browse/ENTESB-12218

@pure-bot
Copy link
Contributor

pure-bot bot commented Nov 29, 2019

Pull request approved by @zregvart - applying pr/approved label

@pure-bot pure-bot bot added the pr/approved Applied by pure-bot when a review is approved label Nov 29, 2019
@zregvart
Copy link
Member

PMD issue:

[INFO] PMD Failure: io.syndesis.server.api.generator.openapi.v2.UnifiedXmlDataShapeGenerator:84 Rule:UnnecessaryFullyQualifiedName Priority:4 Unnecessary use of fully qualified name 'Optional.ofNullable' due to existing static import 'java.util.Optional.ofNullable'.
[INFO] PMD Failure: io.syndesis.server.api.generator.openapi.v3.UnifiedXmlDataShapeGenerator:83 Rule:UnnecessaryFullyQualifiedName Priority:4 Unnecessary use of fully qualified name 'Optional.ofNullable' due to existing static import 'java.util.Optional.ofNullable'.

@christophd christophd force-pushed the issue/12218/fix-openapi-3-support branch from bf47a94 to ec5a23f Compare November 29, 2019 18:37
@christophd christophd merged commit 478bab3 into syndesisio:master Nov 29, 2019
@syndesisio-bot
Copy link

@christophd The bot could not transition the ticket automatically, please update this Jira ticket manually: https://issues.jboss.org/browse/ENTESB-12218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/approved Applied by pure-bot when a review is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants