ENTESB-12330: Allow for specifying a custom resource on install #7410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* install.go * Moves the custom-resource switch to the `install app` command * install_app.go * Handles a custom resource being specified. * Loads it, checks its a syndesis schema, applies it * Provides tests for providing a custom resource
…ripts * Allows custom resource to be specified on the command line then pushed down for processing by the operator
pure-bot
bot
added
the
pr/review-requested
|
@phantomjinx The bot could not transition the ticket automatically, please update this Jira ticket manually: https://issues.redhat.com/browse/ENTESB-12330 |
lgarciaaco
approved these changes
Dec 16, 2019
| @@ -99,6 +99,7 @@ func New(parent *internal.Options) *cobra.Command { | |||
| }, | |||
| } | |||
| app.PersistentFlags().StringVarP(&o.addons, "addons", "", "", "a comma separated list of addons that should be enabled") | |||
There was a problem hiding this comment.
Can't we remove the addons option now?
There was a problem hiding this comment.
Probably. I'll put it in on the TODO list.
|
Pull request approved by @lgarciaaco - applying pr/approved label |
1 similar comment
|
Pull request approved by @lgarciaaco - applying pr/approved label |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.