Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENTESB-12331] Improved Kafka broker discovery using custom cla… #7432

Merged
merged 5 commits into from Jan 10, 2020

Conversation

Delawen
Copy link
Contributor

@Delawen Delawen commented Dec 17, 2019

Now the version is not forced, it should discover all kafkas even if a new version is rolled.

Continuation of #7409

@Delawen Delawen added the cat/enhancement Enhancements to existing features and capabilities label Dec 17, 2019
@pure-bot pure-bot bot added the pr/review-requested Use this if you want to have a review. pure-bot will prevent merging if set and no review given label Dec 17, 2019
@syndesisio-bot
Copy link

@Delawen The bot could not transition the ticket automatically, please update this Jira ticket manually: https://issues.redhat.com/browse/ENTESB-12331

Copy link
Member

@zregvart zregvart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Found some nits to nit about.

Copy link
Contributor

@christophd christophd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I like this! But we have some new dependency issues on CircleCi for connector-kafka

@Delawen
Copy link
Contributor Author

Delawen commented Jan 9, 2020

Oh great, missed the last commit.

@zregvart zregvart changed the title [ENTESB-12331] Improved Kafka broker discovery using custom classes [ENTESB-12331] Improved Kafka broker discovery using custom cla… Jan 10, 2020
@zregvart zregvart merged commit ea610c3 into syndesisio:master Jan 10, 2020
@syndesisio-bot
Copy link

@Delawen The bot could not transition the ticket automatically, please update this Jira ticket manually: https://issues.redhat.com/browse/ENTESB-12331

@Delawen Delawen deleted the ENTESB-12331 branch August 19, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/enhancement Enhancements to existing features and capabilities pr/review-requested Use this if you want to have a review. pure-bot will prevent merging if set and no review given
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants