New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENTESB-12331] Improved Kafka broker discovery using custom cla… #7432
Conversation
@Delawen The bot could not transition the ticket automatically, please update this Jira ticket manually: https://issues.redhat.com/browse/ENTESB-12331 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Found some nits to nit about.
app/connector/kafka/src/main/java/io/syndesis/connector/kafka/KafkaMetaDataRetrieval.java
Outdated
Show resolved
Hide resolved
app/connector/kafka/src/main/java/io/syndesis/connector/kafka/KafkaMetaDataRetrieval.java
Outdated
Show resolved
Hide resolved
app/connector/kafka/src/main/java/io/syndesis/connector/kafka/KafkaMetaDataRetrieval.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I like this! But we have some new dependency issues on CircleCi for connector-kafka
app/connector/kafka/src/main/java/io/syndesis/connector/kafka/KafkaMetaDataRetrieval.java
Outdated
Show resolved
Hide resolved
Oh great, missed the last commit. |
app/connector/kafka/src/main/java/io/syndesis/connector/kafka/KafkaMetaDataRetrieval.java
Outdated
Show resolved
Hide resolved
app/connector/kafka/src/main/java/io/syndesis/connector/kafka/model/crd/KafkaResource.java
Show resolved
Hide resolved
interact with Kubernetes. Continuation of syndesisio#7409
Co-Authored-By: Zoran Regvart <zoran@regvart.com>
As suggested by @squakez
@Delawen The bot could not transition the ticket automatically, please update this Jira ticket manually: https://issues.redhat.com/browse/ENTESB-12331 |
Now the version is not forced, it should discover all kafkas even if a new version is rolled.
Continuation of #7409