Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ENTESB-12352) api provider integration step can be replaced #7671

Merged
merged 4 commits into from Jan 24, 2020

Conversation

kahboom
Copy link
Contributor

@kahboom kahboom commented Jan 23, 2020

This PR fixes the bug that allows users to replace the API provider step when creating an integration.

API provider step no longer allows users to go back and change/replace the action:

Screenshot 2020-01-23 16 03 40

Dropbox step, as an example, remains unaffected:

Screenshot 2020-01-23 16 04 31

@pull-request-size pull-request-size bot added the size/m Medium label Jan 23, 2020
Copy link
Contributor

@gashcrumb gashcrumb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zregvart
Copy link
Member

We could be running into memory issues in the build, looks vaguely similar to the issues we had building UI and the solution we found was to increase the Nodejs process memory:

INFO] lerna ERR! yarn run build exited 1 in '@syndesis/syndesis'
[INFO] lerna ERR! yarn run build stdout:
[INFO] $ npm-run-all copyasset:*
[INFO] $ cpr ../packages/atlasmap-assembly/dist/atlasmap public/atlasmap -d
[INFO] $ cpr ../packages/apicurio-assembly/dist/apicurio public/apicurio -d
[INFO] $ NODE_OPTIONS=--max-old-space-size=3072 craco build
[INFO] Creating an optimized production build...
[INFO] Failed to compile.
[INFO] 
[INFO] Failed to minify the bundle. Error: static/js/2.23b4bdc6.chunk.js from Terser
[INFO] Error: Call retries were exceeded
[INFO]     at compiler.run (/workspace/app/ui-react/node_modules/react-scripts/scripts/build.js:196:23)
[INFO]     at finalCallback (/workspace/app/ui-react/node_modules/react-scripts/node_modules/webpack/lib/Compiler.js:257:39)
[INFO]     at hooks.done.callAsync.err (/workspace/app/ui-react/node_modules/react-scripts/node_modules/webpack/lib/Compiler.js:273:13)
[INFO]     at AsyncSeriesHook.eval [as callAsync] (eval at create (/workspace/app/ui-react/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:24:1)
[INFO]     at AsyncSeriesHook.lazyCompileHook (/workspace/app/ui-react/node_modules/tapable/lib/Hook.js:154:20)
[INFO]     at onCompiled (/workspace/app/ui-react/node_modules/react-scripts/node_modules/webpack/lib/Compiler.js:271:21)
[INFO]     at hooks.afterCompile.callAsync.err (/workspace/app/ui-react/node_modules/react-scripts/node_modules/webpack/lib/Compiler.js:681:15)
[INFO]     at AsyncSeriesHook.eval [as callAsync] (eval at create (/workspace/app/ui-react/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1)
[INFO]     at AsyncSeriesHook.lazyCompileHook (/workspace/app/ui-react/node_modules/tapable/lib/Hook.js:154:20)
[INFO]     at compilation.seal.err (/workspace/app/ui-react/node_modules/react-scripts/node_modules/webpack/lib/Compiler.js:678:31)
[INFO]     at AsyncSeriesHook.eval [as callAsync] (eval at create (/workspace/app/ui-react/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1)
[INFO]     at AsyncSeriesHook.lazyCompileHook (/workspace/app/ui-react/node_modules/tapable/lib/Hook.js:154:20)
[INFO]     at hooks.optimizeAssets.callAsync.err (/workspace/app/ui-react/node_modules/react-scripts/node_modules/webpack/lib/Compilation.js:1423:35)
[INFO]     at AsyncSeriesHook.eval [as callAsync] (eval at create (/workspace/app/ui-react/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1)
[INFO]     at AsyncSeriesHook.lazyCompileHook (/workspace/app/ui-react/node_modules/tapable/lib/Hook.js:154:20)
[INFO]     at hooks.optimizeChunkAssets.callAsync.err (/workspace/app/ui-react/node_modules/react-scripts/node_modules/webpack/lib/Compilation.js:1414:32)
[INFO] Read more here: https://bit.ly/CRA-build-minify

@kahboom kahboom merged commit 0073eff into syndesisio:master Jan 24, 2020
@kahboom kahboom deleted the api-provider-finish branch January 24, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/m Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants