Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DV details page updates #8004

Merged
merged 1 commit into from Mar 3, 2020
Merged

DV details page updates #8004

merged 1 commit into from Mar 3, 2020

Conversation

mdrillin
Copy link
Contributor

@mdrillin mdrillin commented Mar 2, 2020

Implement requested UX changes in ENTESB-12898

  • adjust vertical margin so that green check icon lines up better with virtualization name
  • adjust padding around submit button on SqlClient page
  • editor page actions - pulled publish action out of kebab menu and made it a secondary button so the upper right menu is more noticeable. The type for custom properties needed fix so that the custom properties could be applied properly.

@pull-request-size pull-request-size bot added the size/m Medium label Mar 2, 2020
@mdrillin mdrillin requested a review from indraraj March 2, 2020 21:45
indraraj
indraraj approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@indraraj indraraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Locally, looks good.

@indraraj indraraj merged commit b677b88 into syndesisio:master Mar 3, 2020
@syndesisio-bot
Copy link

@mdrillin The bot could not transition the ticket automatically, please update this Jira ticket manually: https://issues.redhat.com/browse/ENTESB-12898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indraraj indraraj indraraj approved these changes

Assignees
No one assigned
Labels
group/datavirt size/m Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdrillin @syndesisio-bot @indraraj