Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(integration): Enable Flows dependencies #8152

Merged
merged 1 commit into from Mar 31, 2020
Merged

feat(integration): Enable Flows dependencies #8152

merged 1 commit into from Mar 31, 2020

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Mar 30, 2020

  • Providing the Flow the possibility to include a list of Dependencies
  • Include the list of Flows dependencies into the Project generated from an Integration

Closes ENTESB-13246

@squakez squakez added the group/integration Library used in the the integration runtimes label Mar 30, 2020
@syndesisio-bot
Copy link

@squakez The bot could not transition the ticket automatically, please update this Jira ticket manually: https://issues.redhat.com/browse/ENTESB-13246

zregvart
zregvart reviewed Mar 30, 2020
View reviewed changes
Copy link
Member

@zregvart zregvart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why flows and not integrations?

...-generator/src/test/java/io/syndesis/integration/project/generator/ProjectGeneratorTest.java Outdated Show resolved Hide resolved
...-generator/src/test/java/io/syndesis/integration/project/generator/ProjectGeneratorTest.java Outdated Show resolved Hide resolved
@squakez
Copy link
Contributor Author

squakez commented Mar 31, 2020

Why flows and not integrations?

The idea is that every flow can have its own dependencies. We've discussed about this and we decided to apply this change at flow instead that at integration.

@lburgazzoli
Copy link
Collaborator

Why flows and not integrations?

The idea is that every flow can have its own dependencies. We've discussed about this and we decided to apply this change at flow instead that at integration.

I think Zoran is right, we should do it also at integration level

@squakez
feat(integration): Enable Flows dependencies
da44fc7 
* Providing the Flow the possibility to include a list of Dependencies
* Include the list of Flows dependencies into the Project generated from an Integration

Closes ENTESB-13246
@zregvart
Copy link
Member

If we plan on publishing (running) flows in separate processes then dependency per flow has some merit. Otherwise I would prefer having dependencies attached to the element that brought the need for the dependency (say connector/step/action) or if this dependency is result of human adding the dependency then that dependency should be at the deployment unit level: and that's integration.

We need to consider the ease of managing these dependencies, again if the human added then management is delegated to the human, if the dependency was added by code the dependency needs to reside near the cause of the addition (connector/step/action) in order to ease the management of it.

@squakez squakez merged commit 74daca3 into syndesisio:master Mar 31, 2020
@syndesisio-bot
Copy link

@squakez The bot could not transition the ticket automatically, please update this Jira ticket manually: https://issues.redhat.com/browse/ENTESB-13246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lburgazzoli lburgazzoli lburgazzoli approved these changes

@christophd christophd Awaiting requested review from christophd

@zregvart zregvart Awaiting requested review from zregvart

Assignees
No one assigned
Labels
group/integration Library used in the the integration runtimes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@squakez @syndesisio-bot @lburgazzoli @zregvart