This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
feat: don't show successful validation for unknown connectors #8678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
|
@avano is this just a transient infra problem causing this to fail? |
the certificate expired 2 hours ago 😁 I'll tweak the wget to ignore the certificate error |
|
ok cool, yep didn't want to keep trying to run them if they were just gonna fail, thanks for looking! |
|
any time, it's ok now :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8608
With this the UI will show:
instead of a successful validation, specifically when the validation response indicates the connector ID is unknown, in other cases as a stopgap the error response will be displayed to the user as an info alert.