ENTESB-14866: Improve logic of OLM Operator-Group installed for jaeger addon #9104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* install.go * Exposes a log-level switch when installing the operator * log-level -> 1 - 10 * operator.yml.tmpl * Marries the log-level parameter to the zap-level of the operator binary when run on the cluster. Zap log already built-in & configured to go
claudio4j
reviewed
Oct 6, 2020
|
I tested on OCP 4.5.13, the jaeger-operator was installed on syndesis namespace |
|
These are the steps to build and install operator log
I have not yet investigated why the current permissions are not working. |
* The naive approach to installing an operator-group in the syndesis ns regardless of other operator-groups is not acceptable as it causes issues with the jaeger operator. * If there is already an all-namespace operator-group installed in any namespace then this will impact the syndesis namespace. The openshift-operators namespace provides one out of the box. This is the designated location for all-namespace operators when installing through the openshift console. * Ensures that the jaeger-operator's subscription ends up in the openshift-operators namespace to be consistent, without specifying it by name. * subscription.go * Finds any installed operator-groups before falling back to creating one in the syndesis namespace. in the case of jaeger. latter should only occur if an all-ns operator-group is not available in the cluster.
phantomjinx
force-pushed
the
jaeger-sub
branch
from
58ad590
to
631bf8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please try out as part of review
The jaeger-operator should now end up being installed in the openshift-operators namespace (same as when installing through the console UI). This is intentional since a global-operators operator-group is already installed in that namespace so syndesis uses that rather than blindly creating its own.
It is also now possible to effectively uninstall the jaeger instance since its CR is owned by the syndesis-operator. Therefore, editing the syndesis CR to disable the jaeger addon will effectively delete the jaeger CR, which in turn causes the jaeger operator (installed in openshift-operators) to remove the syndesis-jaeger instance.