Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui) [ENTESB-11603] prevent configured properties from being cleared in integration + API connector editors #9284

Merged
merged 2 commits into from Jan 20, 2021
Merged

fix(ui) [ENTESB-11603] prevent configured properties from being cleared in integration + API connector editors #9284

merged 2 commits into from Jan 20, 2021

Conversation

kahboom
Copy link
Contributor

@kahboom kahboom commented Jan 18, 2021

fixes ENTESB-11603

  • for the Create Connection fix, include configuredProperties in backHref of the ReviewPage, since there is already a check in place for configured fields in ConfigurationPage
  • went ahead and fixed this for the Security step of the API client connector as well, which, conversely, did not check for configured fields in SecurityPage, so this check was added

Kapture 2021-01-18 at 15 12 45

@pull-request-size pull-request-size bot added the size/s Small label Jan 18, 2021
@kahboom kahboom mentioned this pull request Jan 18, 2021
Merged
gashcrumb
gashcrumb approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@gashcrumb gashcrumb left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zregvart zregvart merged commit 7992119 into syndesisio:master Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gashcrumb gashcrumb gashcrumb approved these changes

@zregvart zregvart zregvart approved these changes

Assignees
No one assigned
Labels
size/s Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kahboom @gashcrumb @zregvart