Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): [ENTESB-15353] - support custom labeling of integration #9718

Merged
merged 5 commits into from Sep 7, 2021

Conversation

kahboom
Copy link
Contributor

@kahboom kahboom commented Sep 1, 2021

Implements ENTESB-15353 to support creating custom labels for integrations. Includes validation of user input.

Screen Shot 2021-08-25 at 20 53 23

Screen Shot 2021-08-25 at 20 54 23

Screen Shot 2021-08-26 at 16 50 07

will follow up with a PR to provide filtering custom labels soon.

add IntegrationEditorLabels component

add story for IntegrationEditorLabels component
rename onSelect for extension list table to prevent conflict

set callback for labels

add arrayToObj and objToArray helper functions for labels
rm label state from SaveIntegrationPage to prevent deep re-rendering, handle changes to label selection

update story

add regex improvements
fix for select option

add tests

add story for no pre-existing labels

remove user-event and relevant tests for now
@kahboom kahboom added cat/feature PR label for a new feature group/ui User interface SPA, talking to the REST backend labels Sep 1, 2021
@pull-request-size pull-request-size bot added the size/xl Extra large label Sep 1, 2021
@kahboom
Copy link
Contributor Author

kahboom commented Sep 6, 2021

retest this please

Copy link
Contributor

@gashcrumb gashcrumb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kahboom kahboom merged commit 6be4746 into syndesisio:1.13.x Sep 7, 2021
@kahboom kahboom deleted the ENTESB-15353-add-labels branch September 7, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/feature PR label for a new feature group/ui User interface SPA, talking to the REST backend size/xl Extra large
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants