ENTESB-18466: Introduces control of OLM upgradeability using OLM OperatorCondition flag #9913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* operator-lib provides factory functions for setting operator conditions
* Calling make test-catalog, the bundle will be built, pushed and added to a copy of the 4.11 catalog. The resulting image can be pushed and used as a catalogsource for testing the OLM install of the bundle metadata.
* The OLM bundle needs the kafka and public-api cluster roles as the operator install action applies the ClusterRoleBindings in assets/infrastructure. The bindings call for these roles by name so they must be installed by the OLM as well as by the syndesis install --cluster-setup
* When operator is installed via OLM, a separate OperatorCondition CR is created which can be updated with an "upgradeable" condition flagging whether the OLM can upgrade the operator * Turn off upgradeable state when * operator is initializing * operator is upgrading * Turn on upgradeable state when * operator has started * operator has completed an upgrade * Finds the OperatorCondition using the deployment name, deployment owner (CSV) and the CSV name (OperatorCondition has same name as the CSV). * Adds conditions tests but cannot completely implement due to operator-framework/operator-lib#103
|
Causing build action to fail. Will investigate ... |
|
I am getting the same build error as reported by CI |
|
@phantomjinx see install/operator/.lib.sh, might good to base these changes on top of #9786 |
* By default, openapi-gen looks for a boilerplace.go.txt file in
${SRC}/go/src/kube-openapi/boilerplate but `go mod vendor`
excludes this directory when vendoring dependencies.
* .lib.sh
* Include our own boilerplate directory and use the
--go-header-file switch to specify its location
* Improve the brevity of the openapi-gen function
* boilerplate.go.txt
* Reflects our licence header rather than kubernetes
* Makefile
* Replace which with command as latter is posix compliant
* Update to kube-openapi version and generated api files
phantomjinx
force-pushed
the
upgradeable-condition
branch
from
dadc76c
to
48d4eaa
Compare
claudio4j
approved these changes
Feb 24, 2022
zregvart
reviewed
Feb 25, 2022
| @@ -0,0 +1,16 @@ | |||
| /* | |||
There was a problem hiding this comment.
This is for code contributed to ASF, we should go with something like https://github.com/syndesisio/syndesis/blob/6cd3b2a97b83bf7d9829e407eeec610382c9cc6d/install/operator/config/boilerplate.go.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks horrendous but first commit is updating dependencies due to use of OperatorLib 0.9.0. Probably only need to review the
go.modand.lib.shchanges. Otherwise, the later 4 commits are more important.