ENTESB-18466 - Reworking of operator conditions ensuring step upgrades #9938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds compile flags for removal of debug symbols from binaries reducing the size by ~15%
* A double upgrade (7.10 -> 7.11.0 -> 7.11.1) does not get to the point of running 7.11.0's Reconcile function before OLM kicks in upgrade to 7.11.1 so need to get the OLM operatorcondition applied before the pod has succeeded * Adds an init-container operator-init to the operator deployment * Objective is find the CSV operatorcondition and disable upgrading * container runs the operator image but has command operator-init instead of operator binary * Operator-init binary compiled in addition to syndesis-operator * Adds ProductName var to deployment template as required for finding the operatorcondition * syndesis_controller.go * Adds in disable states to start of Reconcile function to handle non-resource use-cases * .../action/... * To allow for operator-init binary to use operatorcondition API, have the productName passed in as a parameter
claudio4j
approved these changes
Apr 25, 2022
zregvart
approved these changes
Apr 25, 2022
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While performing a double upgrade, ie. 1.13.0 -> 1.14.0 -> 1.14.1, the reconcile function was never being called and hence the operatorcondition for delaying the operator upgrade was never applied. To workaround this a new init-container is executed in front of the operator container that calls a partner binary (operator-init). This binary sits in the same operator image so no need to build another image (just override the command).
operator-init detects existence of a Syndesis resource, and if present, applies the operatorcondition. Since this is an init-container, the operator has not even started so no race conditions and guranteed that the next upgrade just cannot start ahead of the operatorcondition being set.
Only when the reconciled has correctly processed the operands, done the upgrade etc., is the operatorcondition released, allowing the next operator to kick in.
The visual manifestation of this is that the 1.14.1 operator appears in the list of operators but remains pending.