Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

de350e breaks build on go1.2 #54

Closed
kortschak opened this issue Jul 5, 2014 · 1 comment
Closed

de350e breaks build on go1.2 #54

kortschak opened this issue Jul 5, 2014 · 1 comment

Comments

@kortschak
Copy link

de350e4 appears to have broken goleveldb on go1.2 due to a send of a chan struct{} on a chan chan<- struct{}. This is clearly a bug in go1.2, but can be mitigated. Please see this PR for details.
@kortschak kortschak mentioned this issue Jul 5, 2014
Closed
syndtr added a commit that referenced this issue Jul 6, 2014
@syndtr
leveldb: Do explicit type conversion of biderectional channel before …
eeefdfa 
…sending to channel with single directional element type

Needed by go1.2. Read issue #54.
@syndtr
Copy link
Owner

syndtr commented Jul 6, 2014

Thanks!

@syndtr syndtr closed this as completed Jul 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kortschak @syndtr