better handling of yaml errors

Sources/MurrayKit/Coding/YAMLCoder.swift

@@ -17,7 +17,11 @@ extension YAMLDecoder: Decoder {
             case let DecodingError.dataCorrupted(inner):
                 switch inner.underlyingError ?? error {
                 case is Errors: throw inner.underlyingError ?? error
-                default: throw Errors.unparsableContent((inner.underlyingError ?? error).localizedDescription)
+                default:
+                    if let underlying = inner.underlyingError as? YamlError {
+                        throw Errors.unparsableContent(underlying.description)
+                    }
+                    throw Errors.unparsableContent((inner.underlyingError ?? error).localizedDescription)
                 }
             default: throw Errors.unparsableContent(error.localizedDescription)
             }

Sources/MurrayKit/Models/CodableFile.swift

@@ -55,7 +55,12 @@ public struct CodableFile<Object: Codable & Hashable>: Hashable {
         let data = try file.read()
         if let ext = file.extension,
            let decoder: Decoder = Self.decoder(from: ext) {
-            try self.init(file: file, object: decoder.decode(data))
+            do {
+                try self.init(file: file, object: decoder.decode(data))
+            } catch {
+                Logger.log(error.localizedDescription, level: .verbose)
+                throw Errors.unparsableFile(file.path)
+            }
 
         } else {
             let decoders: [Decoder] = [JSONDecoder(), YAMLDecoder()]

Tests/MurrayKitTests/CodableTests.swift

@@ -0,0 +1,24 @@
+//
+//  File.swift
+//
+//
+//  Created by Stefano Mondino on 01/05/23.
+//
+
+import Foundation
+@testable import MurrayKit
+import XCTest
+import Yams
+
+class CodableTests: TestCase {
+    func testYAMLFileProducesProperError() throws {
+        let scenario = Scenario.wrongMurrayfile
+        let root = try scenario.make()
+        XCTAssertThrowsError(try CodableFile<Murrayfile>(in: root).object) { error in
+            switch error as? Errors ?? .unknown {
+            case .unparsableFile: return
+            default: XCTFail("\(error) is not of expected type")
+            }
+        }
+    }
+}

Tests/MurrayKitTests/Mocks/WrongMurrayfile/Murrayfile.yml

@@ -0,0 +1,3 @@
+environment:
+  someProperty: {{name}} but this is probably wrong because is missing surrounding quotes
+packages: []

Tests/MurrayKitTests/Utilities/Scenario.swift

@@ -13,13 +13,13 @@ extension Folder {
         try Folder(path: Bundle.module.resourcePath ?? Bundle.module.bundlePath)
             .subfolder(at: "Mocks/\(name)")
     }
-    
+
     static func testFolder() throws -> Folder {
         try Folder
             .temporary
             .createSubfolderIfNeeded(withName: "Murray")
     }
-    
+
     static func emptyTestFolder() throws -> Folder {
         try? Folder.temporary.subfolder(named: "emptyTest").delete()
         return try Folder
@@ -30,7 +30,7 @@ extension Folder {
 
 struct Scenario {
     let name: String
-    
+
     func make() throws -> Folder {
         let origin = try Folder.mock(at: name)
 
@@ -39,7 +39,7 @@ struct Scenario {
         try? destinationParent
             .subfolder(named: name)
             .delete()
-        
+
         try origin
             .copy(to: destinationParent)
 
@@ -51,21 +51,26 @@ struct Scenario {
 }
 
 extension Scenario {
-
     static var simpleJSON: Scenario {
         .init(name: "SimpleJSON")
     }
 
     static var simpleYaml: Scenario {
         .init(name: "SimpleYaml")
     }
-
+
+    static var wrongMurrayfile: Scenario {
+        .init(name: "WrongMurrayfile")
+    }
+
     static var cloneOrigin: Scenario {
         .init(name: "Skeleton")
     }
+
     static var cloneOriginInSubfolder: Scenario {
         .init(name: "SkeletonInSubfolder")
     }
+
     static func folder() throws -> Folder {
         try Folder.testFolder()
     }