Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error animating advanced spline. #1480

Closed
strujillodv opened this issue Jun 8, 2020 · 16 comments
Closed

Error animating advanced spline. #1480

strujillodv opened this issue Jun 8, 2020 · 16 comments
Labels
Milestone

Comments

@strujillodv
Copy link

Synfig version & platform: AppImage 1.3.14 - Archlinux KDE

Issue description:

Animate an advanced spline doesn't work well in development version 1.3.14.

You searched for -> Version 1.2.2

Version 1.2.2
https://drive.google.com/file/d/1N7LegIjv0jKZtsYe0gDWepUZFnG6Io8p/view?usp=sharing

The opted -> Version 1.3.14

Version 1.3.14
https://drive.google.com/file/d/1LgKH5AcSeAv8Ve_xKrUs_j9c6R3Efa4X/view?usp=sharing

File exercise: https://drive.google.com/file/d/1QtYhewPdsbh80UH9HNHr2M5Vsz0Mp50q/view?usp=sharing

@rodolforg
Copy link
Contributor

1.3.11 : ok
1.3.12 : bad :P

@strujillodv , in the meanwhile, just type a number close enough to 1.0 in width point poistion, like 0.9999 , but no 1.0

@strujillodv
Copy link
Author

@rodolforg, Changing to a value less than 1.0 it does not work,

@rodolforg
Copy link
Contributor

Here it worked: the starting point fixed in 0.00001 instead of 0 and end width point moves until 0.9999 or something like that.
I'll try again later.

Devs: Anyway, after a git bisect, the guilty commit
c35c747

@FirasH
Copy link
Member

FirasH commented Jun 9, 2020

#1329 is the same issue?

@morevnaproject morevnaproject added this to the v1.4.0 milestone Jun 10, 2020
@morevnaproject
Copy link
Member

Agrh, again outline issues! 🤣

@rodolforg
Copy link
Contributor

Looped advanced-outline layers with 3 vertices and 2 width points (called here as WP).
I changed the Side Type Before of the first WP and the Side Type After of the last WP as shown. The remaining side types are set Interpolation.
I also changed the position of both WP as also shown.

So we can notice that the specific cases of WP in the boundaries are an issue.
Other issue is that the sharp cuspid is not as expected (it doesn't "go straight" to the corner).
And for last we can see that if a WP is at the beginning (0.0), it shows the cuspid shape even though the last WP is not near the end of spline (as shown in second row of last column)

looped-advanced-line-tip-test

@morevnaproject

@rodolforg
Copy link
Contributor

I colored to highlight what is wrong (red) and what is right (green) regarding the WP positions and the cuspid shape.
looped-advanced-line-tip-test
looped-advanced-line-tip-test.zip

@morevnaproject
Copy link
Member

@rodolforg Thank you so much! I am investigating this issue now... ^__^

@morevnaproject
Copy link
Member

You searched for -> Version 1.2.2

Version 1.2.2

The opted -> Version 1.3.14

Version 1.3.14

I can see there are two different issues here.

First one - line visible where is shouldn't - is addressed in #1518.

Second issue is in looped spline (triangle) - the position of animated widthpoint is wrong. This is related to issue discussed in #314 (comment). It was fixed, but seems it still appears for cases when widthpoint is animated. Needs further investigation. (Possibly, I need to look how Animated valuenode handles widthpoints...)

@morevnaproject morevnaproject moved this from Testing Now to In progress in Konstantin's Workspace Jul 4, 2020
@rodolforg
Copy link
Contributor

Second issue is in looped spline (triangle) - the position of animated widthpoint is wrong. This is related to issue discussed in #314 (comment)

I don't think it is wrong.
The Sif file was created in 1.3.14. Opening it in 1.2 will always have this problem.
The inverse (file 1.2 in 1.3.14) was fixed

@morevnaproject
Copy link
Member

Hey, you right! False alarm. 😄
That's great!

@strujillodv
Copy link
Author

strujillodv commented Jul 18, 2020

@morevnaproject The error continues

Log Synfig

Synfig-git built on July 17

Version 1.2.2

Synfig stable

Version 1.2.2

@rodolforg
Copy link
Contributor

rodolforg commented Jul 18, 2020

@strujillodv It was fixed in master and 1.3.x branches.

What git branch did you use it?

@strujillodv
Copy link
Author

@rodolforg this is the version
Log Synfig

@rodolforg
Copy link
Contributor

@strujillodv strange enough I can't find that Revision ID in master branch.
However, the fix was merged into master branch July 12.

So please update your master branch and build it again:

  • If you downloaded the sourcecode in a zip file, redo it
  • If you used git commands, call git pull origin

@strujillodv
Copy link
Author

strujillodv commented Jul 18, 2020

@rodolforg Sorry, my mistake had not updated the repository before testing.

It is working very well

Gif created with Synfig-git

Version 1.2.2

@morevnaproject morevnaproject removed this from In progress in Konstantin's Workspace Jul 20, 2020
@rodolforg rodolforg mentioned this issue Jul 21, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants