Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate ignores all layers except the first one #1590

Closed
Svarov-RZM opened this issue Jul 27, 2020 · 6 comments · Fixed by #1829
Closed

Duplicate ignores all layers except the first one #1590

Svarov-RZM opened this issue Jul 27, 2020 · 6 comments · Fixed by #1829
Labels
Bug Confirmed Critical
Milestone
v1.4.1

Comments

@Svarov-RZM
Copy link
Contributor

Issue description

Say you have Duplicate layer over two others layers such as Translate and Circle. Each of layers have special conversions: Translate shifts X value with each iteration, Circle changes color with each iteration. The problem is that only Translate layer properly calculates duplicate conversion, the other one is ignored.

This picture illustrates the problem:
DupBug1315

Pay attention that in 1.0.2 version not only circle shifts its value, but also changes color.
Test sif file is also attached.
DupBug.zip

Affected versions

Synfig 1.2.2 and higher.
@rodolforg
Copy link
Contributor

rodolforg commented Jul 28, 2020 •
edited

Confirmed and in master branch too. It only affects the layer immediately below it.
Via git log, the change in layer_duplicate between 1.0 and 1.2 seems to be the Cobra renderer implementation.

@ice0 ice0 added this to the v1.4.0 milestone Sep 29, 2020
rodolforg added a commit to rodolforg/synfig that referenced this issue Nov 9, 2020
@rodolforg
fix Duplicate layer ignoring all layers but the first one
81c6df0 
fix synfig#1590
@rodolforg rodolforg mentioned this issue Nov 9, 2020
Merged
@rodolforg
Copy link
Contributor

@Svarov-RZM , if you want to/can test it… here it is :)

@Svarov-RZM
Copy link
Contributor Author

@rodolforg
I've tested your branch, duplicate layer now works as expected. Additionally, it fixes particle template which I am a huge fan of. Many thanks for solving this issue, you rock man!

@rodolforg
Copy link
Contributor

it fixes particle template

I don't have any idea what it is, but I'm glad it works now. lol

@morevnaproject
Copy link
Member

I don't have any idea what it is, but I'm glad it works now. lol

https://wiki.synfig.org/Particles_V2.0 ^__^

ice0 pushed a commit that referenced this issue Nov 11, 2020
@rodolforg
fix Duplicate layer ignoring all layers but the first one (#1829)
985afc4 
fix #1590
ice0 pushed a commit to ice0/synfig that referenced this issue Dec 30, 2020
@rodolforg @ice0
fix Duplicate layer ignoring all layers but the first one (synfig#1829)
001138e 
fix synfig#1590

(cherry picked from commit 985afc4)
ice0 pushed a commit to ice0/synfig that referenced this issue Feb 28, 2021
@rodolforg @ice0
fix Duplicate layer ignoring all layers but the first one (synfig#1829)
2582f25 
fix synfig#1590

(cherry picked from commit 985afc4)
@morevnaproject morevnaproject added this to Testing Now in Konstantin's Workspace Apr 18, 2021
@morevnaproject morevnaproject removed this from Testing Now in Konstantin's Workspace Apr 18, 2021
morevnaproject pushed a commit that referenced this issue Apr 20, 2021
@rodolforg @morevnaproject
fix Duplicate layer ignoring all layers but the first one (#1829)
5823efb 
fix #1590

(cherry picked from commit 985afc4)
@rodolforg rodolforg modified the milestones: v1.4.0, v1.4.1 May 9, 2021
@rodolforg
Copy link
Contributor

This issue is already fixed in v1.4.1.

morevnaproject pushed a commit to morevnaproject/synfig that referenced this issue Aug 9, 2021
@rodolforg @morevnaproject
fix Duplicate layer ignoring all layers but the first one (synfig#1829)
a043cb4 
fix synfig#1590

(cherry picked from commit 985afc4)
morevnaproject pushed a commit to morevnaproject/synfig that referenced this issue Aug 9, 2021
@rodolforg @morevnaproject
fix Duplicate layer ignoring all layers but the first one (synfig#1829)
ffc9c49 
fix synfig#1590

(cherry picked from commit 985afc4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Confirmed Critical
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging a pull request may close this issue.

fix Duplicate layer ignoring all layers but the first one rodolforg/synfig
4 participants
@morevnaproject @rodolforg @ice0 @Svarov-RZM