Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lottie exporter] Implement use-defs #2182

Merged
merged 5 commits into from Jun 16, 2021
Merged

[Lottie exporter] Implement use-defs #2182

merged 5 commits into from Jun 16, 2021

Conversation

AnishGG
Copy link
Member

@AnishGG AnishGG commented Jun 9, 2021 •
edited

Fixes: #1243
Fixes: #1242

I have tested some sample files, and this fix works for them. @rodolforg can you please review this. ^__^

@AnishGG AnishGG requested a review from rodolforg June 9, 2021 14:25
@AnishGG
Copy link
Member Author

AnishGG commented Jun 9, 2021

So the lottie-build fails for this. Let me check it out.

@AnishGG AnishGG marked this pull request as draft June 9, 2021 14:38
@AnishGG AnishGG marked this pull request as ready for review June 9, 2021 15:23
@AnishGG
Copy link
Member Author

AnishGG commented Jun 9, 2021

So the lottie-build fails for this. Let me check it out.

It is fixed now.

@AnishGG AnishGG changed the title Implement use-defs for Lottie exporter [Lottie exporter] Implement use-defs Jun 9, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jun 11, 2021

This pull request introduces 1 alert when merging ebbd3d0 into 93365c5 - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

@rodolforg
Copy link
Contributor

That error seems to be gone, but I got another one while testing with that walk.sif example file:
Captura de tela de 2021-06-11 06-24-59

Are they related?

@AnishGG
Copy link
Member Author

AnishGG commented Jun 11, 2021

Are they related?

Nope, this a different but known error.

079-ATF-skeleton-animated-spline.sif test file fails with the same error. You can have a look at the same here: https://travis-ci.com/github/AnishGG/synfig/jobs/512991945#L1677

@AnishGG
Copy link
Member Author

AnishGG commented Jun 13, 2021

@ice0 I think this PR is ready for merging. 😀

@ice0 ice0 merged commit fd00d1c into synfig:master Jun 16, 2021
@ice0
Copy link
Collaborator

ice0 commented Jun 16, 2021

Merged. Thank you!

@AnishGG AnishGG mentioned this pull request Jun 28, 2021
Open
rodolforg added a commit to rodolforg/synfig that referenced this pull request Jul 8, 2021
@rodolforg
Update Lottie Exporter plugin
c9ed76a 
- Convert methods not working with radius of simple circle layer (synfig#1101)
- [Lottie exporter] Add support for variable gamma correction (synfig#1174)
- Changes made to offsetKeyFrame file (synfig#1233)
- Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587)
- Add support for blur layers (synfig#1505)
- Add support for Outline layer without variable widths (synfig#1647)
- Improve support for exported values (synfig#2182)
- Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
rodolforg added a commit to rodolforg/synfig that referenced this pull request Jul 10, 2021
@rodolforg
Update Lottie Exporter plugin
3aa9490 
- Convert methods not working with radius of simple circle layer (synfig#1101)
- [Lottie exporter] Add support for variable gamma correction (synfig#1174)
- Changes made to offsetKeyFrame file (synfig#1233)
- Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587)
- Add support for blur layers (synfig#1505)
- Add support for Outline layer without variable widths (synfig#1647)
- Improve support for exported values (synfig#2182)
- Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
rodolforg added a commit to rodolforg/synfig that referenced this pull request Jul 10, 2021
@rodolforg
Update Lottie Exporter plugin
2743898 
- Convert methods not working with radius of simple circle layer (synfig#1101)
- [Lottie exporter] Add support for variable gamma correction (synfig#1174)
- Changes made to offsetKeyFrame file (synfig#1233)
- Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587)
- Add support for blur layers (synfig#1505)
- Add support for Outline layer without variable widths (synfig#1647)
- Improve support for exported values (synfig#2182)
- Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
@rodolforg rodolforg mentioned this pull request Jul 12, 2021
Merged
@morevnaproject morevnaproject added this to Release Notes in v1.4.2 Jul 12, 2021
morevnaproject pushed a commit that referenced this pull request Jul 12, 2021
@rodolforg @morevnaproject
Update Lottie Exporter plugin
f212c12 
- Convert methods not working with radius of simple circle layer (#1101)
- [Lottie exporter] Add support for variable gamma correction (#1174)
- Changes made to offsetKeyFrame file (#1233)
- Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (#1236 #1254 #1286 #1363 #1409 #1447 #1446 #1516 #1515 #1593 #1586 #1619 #1606 #1650 #1587)
- Add support for blur layers (#1505)
- Add support for Outline layer without variable widths (#1647)
- Improve support for exported values (#2182)
- Some code cleanup (#1199 #1213 #1226 #1456 #2061)
@AnishGG AnishGG deleted the 993 branch July 14, 2021 15:17
morevnaproject pushed a commit to morevnaproject/synfig that referenced this pull request Aug 9, 2021
@rodolforg @morevnaproject
Update Lottie Exporter plugin
73bac78 
- Convert methods not working with radius of simple circle layer (synfig#1101)
- [Lottie exporter] Add support for variable gamma correction (synfig#1174)
- Changes made to offsetKeyFrame file (synfig#1233)
- Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587)
- Add support for blur layers (synfig#1505)
- Add support for Outline layer without variable widths (synfig#1647)
- Improve support for exported values (synfig#2182)
- Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
morevnaproject pushed a commit to morevnaproject/synfig that referenced this pull request Aug 9, 2021
@rodolforg @morevnaproject
Update Lottie Exporter plugin
a6ea98a 
- Convert methods not working with radius of simple circle layer (synfig#1101)
- [Lottie exporter] Add support for variable gamma correction (synfig#1174)
- Changes made to offsetKeyFrame file (synfig#1233)
- Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587)
- Add support for blur layers (synfig#1505)
- Add support for Outline layer without variable widths (synfig#1647)
- Improve support for exported values (synfig#2182)
- Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
morevnaproject pushed a commit to morevnaproject/synfig that referenced this pull request Aug 10, 2021
@rodolforg @morevnaproject
Update Lottie Exporter plugin
dd3adbe 
- Convert methods not working with radius of simple circle layer (synfig#1101)
- [Lottie exporter] Add support for variable gamma correction (synfig#1174)
- Changes made to offsetKeyFrame file (synfig#1233)
- Add support for converters: sine, cos, integer, linear gradient, aTan2, Vector angle, radial_composite, radial gradient, vector x, vector y, power, dot product, logarithm, reciprocal, range, vector length, not (synfig#1236 synfig#1254 synfig#1286 synfig#1363 synfig#1409 synfig#1447 synfig#1446 synfig#1516 synfig#1515 synfig#1593 synfig#1586 synfig#1619 synfig#1606 synfig#1650 synfig#1587)
- Add support for blur layers (synfig#1505)
- Add support for Outline layer without variable widths (synfig#1647)
- Improve support for exported values (synfig#2182)
- Some code cleanup (synfig#1199 synfig#1213 synfig#1226 synfig#1456 synfig#2061)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodolforg rodolforg rodolforg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v1.4.2
Release Notes
Milestone
Lottie: Export animation for web
3 participants
@AnishGG @rodolforg @ice0