Fix Orientation parameter display on Text Tool Options Panel #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 4 alerts when merging 3c65d63 into 19a88f4 - view on LGTM.com new alerts:
|
rodolforg
force-pushed
the
fix-text-tool-widget-vector
branch
from
3c65d63
to
d3adb7f
Compare
|
Last push fixed the LGTM above :) |
rodolforg
commented
Oct 20, 2021
| @@ -446,7 +446,7 @@ class SetsModel : public Gtk::TreeModel::ColumnRecord | |||
| class Preferences : public synfigapp::Settings | |||
| { | |||
| public: | |||
| virtual bool get_value(const synfig::String& key, synfig::String& value)const | |||
| virtual bool get_raw_value(const synfig::String& key, synfig::String& value)const override | |||
There was a problem hiding this comment.
FYI I renamed to avoid clashes and confusions with the new get_value methods
rodolforg
commented
Oct 20, 2021
Comment on lines
+346
to
+352
| set_feather_size(Distance( | ||
| settings.get_value("bline.feather", 0.0), | ||
| App::distance_system) | ||
| ); |
There was a problem hiding this comment.
This change inherits the bug already present in the released Synfig apps.
It ignores the unit system it was saved - that may different of current App preference...
Another PR should fix it
ice0
reviewed
Oct 20, 2021
rodolforg
force-pushed
the
fix-text-tool-widget-vector
branch
3 times, most recently
from
e7b8f8d
to
0dd3391
Compare
|
Rebased |
and they include a default_value argument
Let us restrict ChangeLocale usage. It can cause trouble for mixing current locale. This commit fixes a problem with Text Tool Options Panel with size and orientation Widget_Vector showing bizarre values regarding decimal separator in some non-English locales (example: Portuguese. Instead of "0,5" it shows "0.50000,00")
rodolforg
force-pushed
the
fix-text-tool-widget-vector
branch
from
0dd3391
to
d163f00
Compare
ice0
approved these changes
Nov 2, 2021
|
Merged. Thank you! |
rodolforg
added a commit
to rodolforg/synfig
that referenced
this pull request
Nov 20, 2021
They are saved with current preferred unit, but units were ignored when loading.
Many tools ignore the unit system a preference value was saved - that may be different
of current App preference/setting when loaded...
So, for example, 1 pixel can become the gigantic 1u (60px).
Test it:
In Preferences, assure the Unit System is 'Pixels'
Select Bline Tool
In Tool Options Panel, set Brush Size to 1.0 px
Draw any Bline in Work Area
Change to Normal Tool
In Preferences, assure the Unit System is 'Units'
(optional: close Synfig and reopen it)
Select Bline Tool again
Draw another Bline
It's way thicker than before. If you check Tool Options Panel, you'll see Brush Size as 1.0u
Mentioned first here:
synfig#2372 (review)
ice0
pushed a commit
that referenced
this pull request
Nov 22, 2021
They are saved with current preferred unit, but units were ignored when loading.
Many tools ignore the unit system a preference value was saved - that may be different
of current App preference/setting when loaded...
So, for example, 1 pixel can become the gigantic 1u (60px).
Test it:
In Preferences, assure the Unit System is 'Pixels'
Select Bline Tool
In Tool Options Panel, set Brush Size to 1.0 px
Draw any Bline in Work Area
Change to Normal Tool
In Preferences, assure the Unit System is 'Units'
(optional: close Synfig and reopen it)
Select Bline Tool again
Draw another Bline
It's way thicker than before. If you check Tool Options Panel, you'll see Brush Size as 1.0u
Mentioned first here:
#2372 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was the LC_NUMERIC locale was changed for loading preferences and the value was set on widget before changing back to proper locale.
This PR reduces the duration of the temporary locale change.