[MacOS M1] Fixed autotools build #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ice0
commented
Nov 18, 2021
ice0
commented
- Autodetect number of threads for compilation on MacOS
- Fixed CPP/LDFLAGS to correctly work with M1 Homebrew
- Fixed boost detection
rodolforg
reviewed
Nov 21, 2021
rodolforg
reviewed
Nov 21, 2021
rodolforg
reviewed
Nov 21, 2021
rodolforg
added a commit
to rodolforg/synfig
that referenced
this pull request
Nov 23, 2021
From ice0 comment on PR synfig#2424: For example, currently we are using #include <harfbuzz/hb.h> instead of <hb.h> but pkg-config returns `harfbuzz/include/harfbuzz`, not just `harfbuzz/include`. This works fine on Linux because all system libraries is already included by compiler. This need to be fixed. (TODO)
rodolforg
added a commit
to rodolforg/synfig
that referenced
this pull request
Nov 23, 2021
From ice0 comment on PR synfig#2424: For example, currently we are using #include <harfbuzz/hb.h> instead of <hb.h> but pkg-config returns `harfbuzz/include/harfbuzz`, not just `harfbuzz/include`. This works fine on Linux because all system libraries is already included by compiler. This need to be fixed. (TODO) -- From ice0 comment on PR synfig#2442: Please remove prefix from `fribidi` too. ``` pkg-config --cflags fribidi -I/usr/include/fribidi ```
ice0
pushed a commit
that referenced
this pull request
Dec 4, 2021
From ice0 comment on PR #2424: For example, currently we are using #include <harfbuzz/hb.h> instead of <hb.h> but pkg-config returns `harfbuzz/include/harfbuzz`, not just `harfbuzz/include`. This works fine on Linux because all system libraries is already included by compiler. This need to be fixed. (TODO) -- From ice0 comment on PR #2442: Please remove prefix from `fribidi` too. ``` pkg-config --cflags fribidi -I/usr/include/fribidi ```
ice0
force-pushed
the
fix-macos-autotools
branch
from
284b045
to
4ea7685
Compare
rodolforg
reviewed
Dec 19, 2021
rodolforg
reviewed
Dec 19, 2021
Comment on lines
+107
to
+109
| # `lib` is required to correctly detect libmng/libjpeg in autotools. Current `configure.ac` script doesn't use | ||
| # `pkg-config` to get library flags (libmng provides pkg-config (.pc) file from 2.0.3, but Debian still using 1.0.1). | ||
| export LDFLAGS="-L$(brew --prefix)/lib ${LDFLAGS}" |
There was a problem hiding this comment.
Ok, I'm lazy enough to fix the jpeg/mng to handle pkg-config and direct lib... So, I'll approve this PR and I hope we remember to fix it there and here XD
rodolforg
previously approved these changes
Dec 19, 2021
- Autodetect number of threads for compilation on MacOS - Fixed CPP/LDFLAGS to correctly work with M1 Homebrew - Fixed Boost library detection
ice0
force-pushed
the
fix-macos-autotools
branch
from
4ea7685
to
135ab81
Compare
rodolforg
approved these changes
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.