Change #include to not... include... harfbuzz or fribidi folder #2442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remove prefix from P.S. Forgot to mention this. |
From ice0 comment on PR synfig#2424: For example, currently we are using #include <harfbuzz/hb.h> instead of <hb.h> but pkg-config returns `harfbuzz/include/harfbuzz`, not just `harfbuzz/include`. This works fine on Linux because all system libraries is already included by compiler. This need to be fixed. (TODO) -- From ice0 comment on PR synfig#2442: Please remove prefix from `fribidi` too. ``` pkg-config --cflags fribidi -I/usr/include/fribidi ```
rodolforg
force-pushed
the
fix-harfbuzz-include
branch
from
d5a8146
to
9a5cea4
Compare
rodolforg
changed the title
Done |
ice0
approved these changes
Nov 23, 2021
|
Merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From ice0 comment on PR #2424:
For example, currently we are using #include <harfbuzz/hb.h> instead of <hb.h>
but pkg-config returns
harfbuzz/include/harfbuzz, not justharfbuzz/include.This works fine on Linux because all system libraries is already included by compiler.
This need to be fixed. (TODO)
--
From ice0 comment on PR #2442:
Please remove prefix from
fribiditoo.