Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distortions at the end of lines made with the drawing tool #2448

Open
Gilraiser opened this issue Nov 29, 2021 · 5 comments · Fixed by #2471
Open

Distortions at the end of lines made with the drawing tool #2448

Gilraiser opened this issue Nov 29, 2021 · 5 comments · Fixed by #2471
Labels
Regression It worked in older stable releases (or dev releases), but not now at master branch or recent release

Comments

@Gilraiser
Copy link

Describe the bug
The drawing tool generates a distortion at the end of the drawing that is made. The error occurs when the contour, region and advanced contour options are activated, whether they are used alone or at the same time.

To Reproduce
Steps to reproduce the behavior:

  1. Click on the drawing tool.
  2. Draw any shape with long click.
  3. Finish the form by releasing the click.
  4. The error can be seen at the end of the line in the drawing.

Expected behavior
It is true that, depending on the modifications that the tool has had, certain variations to what is drawn are expected, such as smoothness. But you would expect the tangent and vertex handles to not get so tangled in the end.

Screenshots

DrawingToolBug2021-11-29.mp4

System information:

  • OS: Arch Linux x64
  • Commit ID: 0ab9d69

Additional comments
I hope the information is useful for everyone.
Thanks for the excellent work :)

@rodolforg
Copy link
Contributor

@Gilraiser do you stay up-to-date via git?
Can you remember when this problem started?
Are you able to git-bisect?

@rodolforg
Copy link
Contributor

via git-log, maybe until this commit, everything could be normal: c3e196e
After it, we made some cleanups that maybe broke it: like feb62c5 4bb7366 2ce7109

@Gilraiser
Copy link
Author

Gilraiser commented Dec 21, 2021

Hello, best regards. I'm sure it started with commit 0ab9d69. I only have experience with git running git clone. Searching the internet, I see that git-bisect is for searching within code when programmers are not sure when the error started. I am very sure that it is in the commit that I have just pointed out where the error started. I reported it immediately as soon as it happened.

@rodolforg
Copy link
Contributor

Yes, git-bisect help us to search the culprit commit.
We say to git what commit we are sure something was good and what commit is in a bad state (normally head commit).
Then it starts checking out the commit in the midway: we build and test and tell if it is a good or a bad commit. Then git checks out other commit, narrowing the search. We keep doing it until it finds a good commit followed by a bad one :)

Anyway, I'll investigate the commit you mentioned. Thank you :)

@rodolforg rodolforg added the Regression It worked in older stable releases (or dev releases), but not now at master branch or recent release label Dec 21, 2021
@genete genete reopened this Jan 3, 2023
@genete
Copy link
Member

genete commented Jan 3, 2023

Issue reappear in SynfigStudio-1.4.4-2022.12.25-osx-b8d62 using MacOS 10.13.6 (17G14042)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Regression It worked in older stable releases (or dev releases), but not now at master branch or recent release
Projects
Konstantin's Workspace
Awaiting triage
v1.6.0
Planned
Development

Successfully merging a pull request may close this issue.

3 participants