Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regression: importing papagayo file didn't show the expected layers #2495

Merged
merged 1 commit into from
May 17, 2022

Conversation

rodolforg
Copy link
Contributor

@rodolforg rodolforg commented Jan 3, 2022

@rodolforg
Copy link
Contributor Author

The problem exists since 1.3.12 :O

@ice0 ice0 added Critical Regression It worked in older stable releases (or dev releases), but not now at master branch or recent release labels Jan 5, 2022
@ice0
Copy link
Collaborator

ice0 commented Jan 5, 2022

@rodolforg
Can you describe why it didn't work?

@rodolforg
Copy link
Contributor Author

Can you describe why it didn't work?

The layer parameter value stored and returned by layer->get_params() depends on current layer time set.
Sometimes it is not set yet, and I didn't want to force it.

Looking it again, in the case I added, we don't need to use layer_switch->get_possible_new_layers(possible_new_layers); as we already got them :)

@rodolforg
Copy link
Contributor Author

rodolforg commented Jan 5, 2022

Example file (copied from the forums):

lipsync version 1
test-sound.wav
60
243
1
	Voice 1
	that's a test
	1
		that's a test
		34
		110
		3
			that's 34 68 4
				34 etc
				43 AI
				52 etc
				60 etc
			a 69 76 1
				69 AI
			test 77 110 4
				77 etc
				86 E
				94 etc
				103 etc

Edited:
Oh, now I saw I already shared the example file in OP lol

@rodolforg
Copy link
Contributor Author

rodolforg commented Feb 15, 2022

Now I avoid the repetition of dynamic_cast() on each (selected) layer parameter.

And there is no need to check the layer_name parameter value(s):

  1. layer_switch->get_possible_new_layers(possible_new_layers) already check its values
  2. this code slice just shows the possible (and existent) layer children: highlighting what layer is currently selected is done elsewhere (LayerTreeStore::get_value_vfunc()).

@morevnaproject
Copy link
Member

Hi! I have finally tested the PR and it works perfectly! Thank you so much!

@morevnaproject
Copy link
Member

Backported to 1.4.3.

@rodolforg rodolforg deleted the fix-2390 branch May 28, 2022 16:45
@rodolforg rodolforg added this to the v1.4.3 milestone Feb 3, 2024
@rodolforg rodolforg removed the Backport label Feb 3, 2024
@rodolforg rodolforg mentioned this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical Regression It worked in older stable releases (or dev releases), but not now at master branch or recent release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Papagayo integration is buggy with synfig v1.3.16
3 participants