Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux version not understands "\" as directory separator #2723

Closed
morevnaproject opened this issue Jul 2, 2022 · 2 comments · Fixed by #2727
Closed

Linux version not understands "\" as directory separator #2723

morevnaproject opened this issue Jul 2, 2022 · 2 comments · Fixed by #2727

Comments

@morevnaproject
Copy link
Member

Describe the bug
Linux version of Synfig does not parses "\" as directory separator (in image filenames).

To Reproduce
Steps to reproduce the behavior:

  1. Download and unpack sample archive - paths.zip
  2. Open paths.sif file.
  3. See image is not displayed -

screenshot_005

In version 1.4.2 it is displayed correctly -

screenshot_004

You can examine image layer, and see its "Filename" property -
screenshot_006

Notice that it uses "\" as directory separator. This usually happens when file was created in WIndows version of Synfig.

Expected behavior
Synfig should treat both "/" and "\" as directory separators.
@morevnaproject
Copy link
Member Author

Originally reported here - https://forums.synfig.org/t/1-5-1/13295/4

@rodolforg
Copy link
Contributor

rodolforg commented Jul 2, 2022 •
edited by morevnaproject

Ouch.
It should be not stored with "\" :( Now it was, we should support both on loading. Argh.

rodolforg added a commit to rodolforg/synfig that referenced this issue Jul 2, 2022
@rodolforg
fix: layers' parameter "filename" accepts backslash as dir separator
6b1f99b 
Maybe we should fix them on canvas loading.
Probably it would be good to uniform them on saving too as well
on choosing via Widget_Filename too.

Fix synfig#2723
@rodolforg rodolforg mentioned this issue Jul 2, 2022
Merged
rodolforg added a commit to rodolforg/synfig that referenced this issue Jul 2, 2022
@rodolforg
fix: layers' parameter "filename" accepts backslash as dir separator
f1c25e0 
Maybe we should fix them on canvas loading.
Probably it would be good to uniform them on saving too as well
on choosing via Widget_Filename too.

Fix synfig#2723
rodolforg added a commit to rodolforg/synfig that referenced this issue Jul 2, 2022
@rodolforg
fix: layers' parameter "filename" accepts backslash as dir separator
4604b7a 
Maybe we should fix them on canvas loading.
Probably it would be good to uniform them on saving too as well
on choosing via Widget_Filename too.

Fix synfig#2723
rodolforg added a commit to rodolforg/synfig that referenced this issue Jul 2, 2022
@rodolforg
fix: layers' parameter "filename" accepts backslash as dir separator
694b028 
Maybe we should fix them on canvas loading.
Probably it would be good to uniform them on saving too as well
on choosing via Widget_Filename too.

Fix synfig#2723
@ice0 ice0 closed this as completed in #2727 Jul 3, 2022
ice0 pushed a commit that referenced this issue Jul 3, 2022
@rodolforg
fix: layers parameter 'filename' does not accept backslash as directo…
9a6b616 
…ry separator (#2727)

Maybe we should fix them on canvas loading.
Probably it would be good to uniform them on saving too as well
on choosing via Widget_Filename too.

Fix #2723
morevnaproject added a commit to morevnaproject-org/RenderChan that referenced this issue Jul 21, 2022
@morevnaproject
Fix parsing paths with foreign slashes
fbeaa1a 
Fix issue with parsing files, which contain foreign slashes in paths
(i.e. windows slashes in unix paths).

The error was discovered by rendering Synfig files,related to this issue - synfig/synfig#2723
@morevnaproject morevnaproject mentioned this issue Jul 21, 2022
Merged
morevnaproject added a commit to morevnaproject-org/RenderChan that referenced this issue Jul 21, 2022
@morevnaproject
fix: Fix parsing paths with foreign slashes (#76)
861f949 
Fix issue with parsing files, which contain foreign slashes in paths (i.e. windows slashes in unix paths).

The error was discovered by rendering Synfig files, related to this issue - synfig/synfig#2723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: layers parameter 'filename' does not accept backslash as directory separator rodolforg/synfig
2 participants
@morevnaproject @rodolforg