fix: Right-clicking a layer on a just opened file shows empty menu #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was introduced by this commit (87cc5d2) When the list of selected layers was empty, then clicking on the layer opened an empty menu. Now the logic has changed: If the layer is in the list of selected layers, then actions are applied to them, if not, then the selection is removed from them and the layer that was clicked becomes selected (and actions applied to it).
|
I'm not sure about this behavior change. Inkscape does it in other way: when multiple objects are selected, right click is about them, no matter where you clicked. I don't know what is better though |
Am I miss something? Inkscape.Test.mp4 |
|
No. It's about difference of versions ;) Gravacao.de.tela.de.09-08-2022.23.39.48.webm |
rodolforg
approved these changes
Aug 10, 2022
morevnaproject
pushed a commit
that referenced
this pull request
Dec 4, 2022
…2781) The issue was introduced by PR #2352 When the list of selected layers was empty, then clicking on the layer opened an empty menu. Now the logic has changed: If the layer is in the list of selected layers, then actions are applied to them, if not, then the selection is removed from them and the layer that was clicked becomes selected (and actions applied to it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was introduced by this commit (87cc5d2)
When the list of selected layers was empty, then
clicking on the layer opened an empty menu.
Now the logic has changed:
If the layer is in the list of selected layers, then
actions are applied to them, if not, then the selection
is removed from them and the layer that was clicked
becomes selected (and actions applied to it).
fix #2779