refactor: removed boost dependency #2792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ice0
reviewed
Aug 12, 2022
|
This pull request introduces 1 alert when merging ce77587 into 0a545cc - view on LGTM.com new alerts:
|
|
I created a file with some random values using a "dynamic" converter and tested it with the current PR and
Do you plan to test it yourself or can we merge it? |
|
Thank you! I am going to test it too now. ^__^ |
|
I have finished testing and it gives exactly the same results for me too! Awesome work. I also checked examples from this page - Please rebase and we are ready to merge! |
|
rebased |
rodolforg
commented
Aug 30, 2022
rodolforg
commented
Aug 30, 2022
implement our own Runge-Kutta54 Cash-Karp, that boost::ode uses in integrate() as claimed in documentation: https://www.boost.org/doc/libs/1_66_0/libs/numeric/odeint/doc/html/boost_numeric_odeint/getting_started/short_example.html Algorithm described here http://www.elegio.it/mc2/rk/doc/p201-cash-karp.pdf As far as I tested, it gives the same results.
it seems the previous implementation sometimes enter in an infinite loop
In my tests, however, some parts of this new code are never reached.
That's the reason the code could be simplified to only this `if` branch
```c++
if (e_4 > 1) {
// No order less than 5th order is possibly good, so abandon current step
Real esttol = e_4;
step_size *= std::max(0.2, VRKF_sf / esttol);
continue;
} else {
// accept 5th order solution
...
}
```
And consequently some variables could vanish.
read previous commit message
|
Done :) |
ice0
changed the title
ice0
approved these changes
Aug 31, 2022
|
Merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement our own Runge-Kutta54 Cash-Karp, that boost::ode
uses in integrate() as claimed in documentation:
https://www.boost.org/doc/libs/1_66_0/libs/numeric/odeint/doc/html/boost_numeric_odeint/getting_started/short_example.html
Algorithm described here
http://www.elegio.it/mc2/rk/doc/p201-cash-karp.pdf
As far as I tested, it gives the same results.