Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: "rule of two" : copy constructor and copy assignment operator #2823

Merged
merged 1 commit into from Sep 9, 2022
Merged

fix: "rule of two" : copy constructor and copy assignment operator #2823

merged 1 commit into from Sep 9, 2022

Conversation

rodolforg
Copy link
Contributor

And copy assignment operator returns reference, not a copy.

@rodolforg
fix: "rule of two" : copy constructor and copy assignment operator
7dc2288 
And copy assignment operator returns reference, not a copy.
@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2022

This pull request fixes 6 alerts when merging 7dc2288 into 1ce65b6 - view on LGTM.com

fixed alerts:

  • 5 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
  • 1 for Overloaded assignment does not return 'this'

@ice0 ice0 merged commit 11387aa into synfig:master Sep 9, 2022
@ice0
Copy link
Collaborator

ice0 commented Sep 9, 2022

Merged. Thank you!

@rodolforg rodolforg deleted the fix-copy-assingment branch September 9, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ice0 ice0 ice0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rodolforg @ice0