Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No context menu when right-clicking on waypoint #2875

Closed
morevnaproject opened this issue Nov 8, 2022 · 1 comment · Fixed by #2877
Closed

No context menu when right-clicking on waypoint #2875

morevnaproject opened this issue Nov 8, 2022 · 1 comment · Fixed by #2877
Labels

Comments

@morevnaproject
Copy link
Member

This is reproducible in current master branch (8bf9c30).

  1. Download and open sample file -
    wp-right-click-bug.sifz.zip
  2. Select group "1".
  3. Try right-clickig on waypoints, which I indicated on screenshot below -
    screenshot_001

Notice that no menu shown after right-click.

For other waypoints menu show normally.

This seems to be related with #2858 fix.

@mohamedAdhamc can you take a look, please? ^__^

@mohamedAdhamc
Copy link
Member

mohamedAdhamc commented Nov 8, 2022

@morevnaproject sure, I will hopefully start looking into it tonight :).

update: seems that this issue happens when the canvas waypoint is only present due to it referring to another groups parameter, but when the canvas waypoint is referring to at least one layers parameter as well it works fine. I will reinvestigate the whole waypoint collection process tomorrow hopefully and I should reach the problem from there hopefully.

update 2: I have come up with a solution here, will clean it up a bit and then submit a PR hopefully tonight (in a few hours) :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants