Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import of raster work is broken in Master #3331

Closed
Svarov-RZM opened this issue Feb 8, 2024 · 12 comments · Fixed by #3332
Closed

Import of raster work is broken in Master #3331

Svarov-RZM opened this issue Feb 8, 2024 · 12 comments · Fixed by #3332

Comments

@Svarov-RZM
Copy link
Contributor

Description
I was preparing to test rodolforg's Curve Warp port and before I got to it I noticed that import of raster images (pngs, jpegs) is broken. For example, an imported png would look like this:
Test

While pngs are a complete mess, jpegs are imported almost correctly but have wrong colors.

To Reproduce
On empty canvas, import any png image through "File->Import". It will look similar to the image above with weird lines and wrong colors.

Expected behavior
It would have been nice if all supported image formats would display correctly.

System information:
Windows 10 Pro, version 2004.
Commit: 7f39534
Something broke very recently I believe.

@yoSachinkr
Copy link

In Appveyor builds, import of raster images except pngs doesn't work at all. Same is with the exports.

@rodolforg
Copy link
Contributor

Something broke very recently I believe.

@Svarov-RZM @yoSachinkr

What is the latest version commit you tested and worked?

@yoSachinkr
Copy link

Something broke very recently I believe.

@Svarov-RZM @yoSachinkr

What is the latest version commit you tested and worked?
It has been like that for me in every Appveyor builds. These builds only import/export pngs and export avi for video.

@rodolforg
Copy link
Contributor

But they import PNG fine or with the issues svarov mentioned in original post?

@yoSachinkr
Copy link

@rodolforg pngs are working fine in SynfigStudio-1.5.2-testing-2024-02-04-win64-9153d for me.

@rodolforg
Copy link
Contributor

@rodolforg pngs are working fine in SynfigStudio-1.5.2-testing-2024-02-04-win64-9153d for me.

But not the jpg in this file?~~~~

@Svarov-RZM
Copy link
Contributor Author

What is the latest version commit you tested and worked?

Last working commit: 613acd2
So broken since: ceb0868

Can you reproduce the problem on your machine? Maybe it's a Windows bug?

P.S. @yoSachinkr is talking about unrelated issue caused by packaging setup of Appveyor where it just doesn't include all the libraries needed for additional functionality. I would assume audio playback doesn't work either in Appveyor builds since mlt libraries aren't included.

@rodolforg
Copy link
Contributor

rodolforg commented Feb 10, 2024

@Svarov-RZM do you know what is the magick++ version do you have? Could you please disable this module just for check if everything else is fine?

ok, I found out the problem ;) Thank you!

rodolforg pushed a commit to rodolforg/synfig that referenced this issue Feb 10, 2024
There was an undefined behavior due to multiple increment
of same variable in multiple function arguments.

fix synfig#3331
@Svarov-RZM
Copy link
Contributor Author

Well, I tested the commit and it fixes the problem... partially.
Jpegs are now imported correctly, but pngs are still wrong like in the picture at the top.

In the MSYS pacman reports that my imagemagick version is mingw-w64-x86_64-imagemagick 7.0.10.11-3

@rodolforg
Copy link
Contributor

Ouch. I didn't test with transparent images

rodolforg pushed a commit to rodolforg/synfig that referenced this issue Feb 12, 2024
There was an undefined behavior due to multiple increment
of same variable in multiple function arguments.

fix synfig#3331
@rodolforg
Copy link
Contributor

rodolforg commented Feb 12, 2024

@Svarov-RZM and now? I believed it is fixed finally.
(by the way, and CurveWarp ? ;) )

rodolforg pushed a commit to rodolforg/synfig that referenced this issue Feb 12, 2024
There was an undefined behavior due to multiple increment
of same variable in multiple function arguments.

fix synfig#3331
rodolforg pushed a commit to rodolforg/synfig that referenced this issue Feb 12, 2024
There was an undefined behavior due to multiple increment
of same variable in multiple function arguments.

fix synfig#3331
@Svarov-RZM
Copy link
Contributor Author

Yes, it is indeed fixed, thank you!

by the way, and CurveWarp ? ;)

Oh, I did some surface tests but don't have a proper conclusion yet. I have a complex work with a lot of Curve Warp layers on top of raster work I was going to test against but raster images were broken. Now that you fixed it, can you please rebase your "cobra-curvewarp" branch to include this fix so I can finish testing?

rodolforg pushed a commit to rodolforg/synfig that referenced this issue Feb 13, 2024
There was an undefined behavior due to multiple increment
of same variable in multiple function arguments.

fix synfig#3331
ice0 pushed a commit that referenced this issue Feb 13, 2024
There was an undefined behavior due to multiple increment
of same variable in multiple function arguments.

fix #3331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants