-
-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import of raster work is broken in Master #3331
Comments
In Appveyor builds, import of raster images except pngs doesn't work at all. Same is with the exports. |
What is the latest version commit you tested and worked? |
|
But they import PNG fine or with the issues svarov mentioned in original post? |
@rodolforg pngs are working fine in SynfigStudio-1.5.2-testing-2024-02-04-win64-9153d for me. |
But not the jpg in this file?~~~~ |
Last working commit: 613acd2 Can you reproduce the problem on your machine? Maybe it's a Windows bug? P.S. @yoSachinkr is talking about unrelated issue caused by packaging setup of Appveyor where it just doesn't include all the libraries needed for additional functionality. I would assume audio playback doesn't work either in Appveyor builds since mlt libraries aren't included. |
@Svarov-RZM ok, I found out the problem ;) Thank you! |
There was an undefined behavior due to multiple increment of same variable in multiple function arguments. fix synfig#3331
Well, I tested the commit and it fixes the problem... partially. In the MSYS pacman reports that my imagemagick version is mingw-w64-x86_64-imagemagick 7.0.10.11-3 |
Ouch. I didn't test with transparent images |
There was an undefined behavior due to multiple increment of same variable in multiple function arguments. fix synfig#3331
@Svarov-RZM and now? I believed it is fixed finally. |
There was an undefined behavior due to multiple increment of same variable in multiple function arguments. fix synfig#3331
There was an undefined behavior due to multiple increment of same variable in multiple function arguments. fix synfig#3331
Yes, it is indeed fixed, thank you!
Oh, I did some surface tests but don't have a proper conclusion yet. I have a complex work with a lot of Curve Warp layers on top of raster work I was going to test against but raster images were broken. Now that you fixed it, can you please rebase your "cobra-curvewarp" branch to include this fix so I can finish testing? |
There was an undefined behavior due to multiple increment of same variable in multiple function arguments. fix synfig#3331
There was an undefined behavior due to multiple increment of same variable in multiple function arguments. fix #3331
Description
I was preparing to test rodolforg's Curve Warp port and before I got to it I noticed that import of raster images (pngs, jpegs) is broken. For example, an imported png would look like this:
While pngs are a complete mess, jpegs are imported almost correctly but have wrong colors.
To Reproduce
On empty canvas, import any png image through "File->Import". It will look similar to the image above with weird lines and wrong colors.
Expected behavior
It would have been nice if all supported image formats would display correctly.
System information:
Windows 10 Pro, version 2004.
Commit: 7f39534
Something broke very recently I believe.
The text was updated successfully, but these errors were encountered: